Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js

Issue 2795193003: DevTools: carefully cleanup script UISourceCodes (Closed)
Patch Set: address comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js b/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
index c8fcef6b4b23303962c7fbecd76161de963e4523..a1ce9bf75696b44b07321de24613ec4ab9fc62e0 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
@@ -57,10 +57,6 @@ Sources.NavigatorView = class extends UI.VBox {
this._navigatorGroupByFolderSetting.addChangeListener(this._groupingChanged.bind(this));
this._initGrouping();
- SDK.targetManager.addModelListener(
- SDK.ResourceTreeModel, SDK.ResourceTreeModel.Events.FrameNavigated, this._frameNavigated, this);
- SDK.targetManager.addModelListener(
- SDK.ResourceTreeModel, SDK.ResourceTreeModel.Events.FrameDetached, this._frameDetached, this);
if (Runtime.experiments.isEnabled('persistence2')) {
Persistence.persistence.addEventListener(
@@ -758,28 +754,6 @@ Sources.NavigatorView = class extends UI.VBox {
}
/**
- * @param {!Common.Event} event
- */
- _frameNavigated(event) {
- var frame = /** @type {!SDK.ResourceTreeFrame} */ (event.data);
- var node = this._frameNodes.get(frame);
- if (!node)
- return;
-
- node.treeNode().title = frame.displayName();
- for (var child of frame.childFrames)
- this._discardFrame(child);
- }
-
- /**
- * @param {!Common.Event} event
- */
- _frameDetached(event) {
- var frame = /** @type {!SDK.ResourceTreeFrame} */ (event.data);
- this._discardFrame(frame);
- }
-
- /**
* @param {!SDK.ResourceTreeFrame} frame
*/
_discardFrame(frame) {
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698