third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js - Issue 2795193003: DevTools: carefully cleanup script UISourceCodes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js

Issue 2795193003: DevTools: carefully cleanup script UISourceCodes (Closed)

Patch Set: address comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-url-comment.html ('k') | third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js

diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js b/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js

index 6a985aa589e145dc815ab61fd97a43bb33151a2c..ebfc037175820568a9cba9d3d79acca7dbf57182 100644

--- a/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js

+++ b/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js

@@ -276,10 +276,8 @@ Bindings.BlackboxManager = class {

var promises = [];

for (var debuggerModel of SDK.targetManager.models(SDK.DebuggerModel)) {

promises.push(this._setBlackboxPatterns(debuggerModel));

- for (var scriptId in debuggerModel.scripts) {

- var script = debuggerModel.scripts[scriptId];

+ for (var script of debuggerModel.scripts())

promises.push(this._addScript(script).then(loadSourceMap.bind(this, script)));

- }

}

Promise.all(promises).then(() => {

var listeners = Array.from(this._listeners);