Make Future.doWhile not delay when the return value is not a future.

Make Future.doWhile not delay when the return value is not a future.

Ditto for Future.forEach, which is based on Future.doWhile.

Update documentation.


Fixes issue #29239
BUG= http://dartbug.com/29239
R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/f380e61b57fec3d55b7929c2b1417f522465f80a

[Lasse Reichstein Nielsen, 2017-04-04 11:20:56]

lrn@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2017-04-05 13:19:25]

LGTM.

https://codereview.chromium.org/2795193002/diff/1/sdk/lib/async/future.dart
File sdk/lib/async/future.dart (right):

https://codereview.chromium.org/2795193002/diff/1/sdk/lib/async/future.dart#n...
sdk/lib/async/future.dart:431: * only when the call returns, and if [f] returns
a `Future<T>`, when
in order. If [f] returns a [Future<T>], waits until that future is completed
before moving to the next element.

https://codereview.chromium.org/2795193002/diff/1/sdk/lib/async/future.dart#n...
sdk/lib/async/future.dart:433: * Returns a [Future] that completes with `null`
when all elements have been
Make this a separate paragraph.

https://codereview.chromium.org/2795193002/diff/1/sdk/lib/async/future.dart#n...
sdk/lib/async/future.dart:437: * Any error from [f], synchronous or
asynchronous, will stop the iteration
Maybe make this a paragraph.

[Lasse Reichstein Nielsen, 2017-04-06 09:49:27]

https://codereview.chromium.org/2795193002/diff/1/sdk/lib/async/future.dart
File sdk/lib/async/future.dart (right):

https://codereview.chromium.org/2795193002/diff/1/sdk/lib/async/future.dart#n...
sdk/lib/async/future.dart:431: * only when the call returns, and if [f] returns
a `Future<T>`, when
On 2017/04/05 13:19:25, floitsch wrote:
> in order. If [f] returns a [Future<T>], waits until that future is completed
> before moving to the next element.

Done.

https://codereview.chromium.org/2795193002/diff/1/sdk/lib/async/future.dart#n...
sdk/lib/async/future.dart:433: * Returns a [Future] that completes with `null`
when all elements have been
On 2017/04/05 13:19:25, floitsch wrote:
> Make this a separate paragraph.

Done.

https://codereview.chromium.org/2795193002/diff/1/sdk/lib/async/future.dart#n...
sdk/lib/async/future.dart:436: * The return values of the calls are discarded.
Reworded slightly.

https://codereview.chromium.org/2795193002/diff/1/sdk/lib/async/future.dart#n...
sdk/lib/async/future.dart:437: * Any error from [f], synchronous or
asynchronous, will stop the iteration
On 2017/04/05 13:19:25, floitsch wrote:
> Maybe make this a paragraph.

Done.

https://codereview.chromium.org/2795193002/diff/1/sdk/lib/async/future.dart#n...
sdk/lib/async/future.dart:441: * it waits for the returned [Future] to complete.
This paragraph is redundant with the second paragraph above, so I removed it.

[Lasse Reichstein Nielsen, 2017-04-06 10:00:23]

Description was changed from

==========
Make Future.doWhile not delay when the return value is not a future.

Ditto for Future.forEach, which is based on Future.doWhile.

Update documentation.


Fixes issue #29239
BUG= http://dartbug.com/29239
==========

to

==========
Make Future.doWhile not delay when the return value is not a future.

Ditto for Future.forEach, which is based on Future.doWhile.

Update documentation.


Fixes issue #29239
BUG= http://dartbug.com/29239
R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f380e61b57fec3d55b7929c2b1417f522465f80a
==========

[Lasse Reichstein Nielsen, 2017-04-06 10:00:24]

Committed patchset #2 (id:20001) manually as
f380e61b57fec3d55b7929c2b1417f522465f80a (presubmit successful).