third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp - Issue 2795173002: Do not show image placeholders for CSS sprites

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp

Issue 2795173002: Do not show image placeholders for CSS sprites (Closed)

Patch Set: Addressed comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp b/third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp

index add2968d9a1859c222b427ea6dc62712e5d447df..cdb9b16ec5add74206cb311cd916c227d488ac95 100644

--- a/third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp

+++ b/third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp

@@ -65,8 +65,8 @@ static ImageResourceContent* CachedImageForCSSValue(CSSValue* value,

return nullptr;

if (value->IsImageValue()) {

- StyleImage* style_image_resource =

- ToCSSImageValue(value)->CacheImage(document);

+ StyleImage* style_image_resource = ToCSSImageValue(value)->CacheImage(

+ document, FetchParameters::kAllowPlaceholder);

if (!style_image_resource)

return nullptr;