Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: third_party/WebKit/Source/core/css/CSSImageSetValue.h

Issue 2795173002: Do not show image placeholders for CSS sprites (Closed)
Patch Set: Addressed kouhei comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSImageSetValue.h
diff --git a/third_party/WebKit/Source/core/css/CSSImageSetValue.h b/third_party/WebKit/Source/core/css/CSSImageSetValue.h
index 5954a337a01b517cd22a9dd08964dd8e7d1fe692..ca36a580c2584b83d60fecbd23e4bdac34666b1e 100644
--- a/third_party/WebKit/Source/core/css/CSSImageSetValue.h
+++ b/third_party/WebKit/Source/core/css/CSSImageSetValue.h
@@ -28,6 +28,7 @@
#include "core/css/CSSValueList.h"
#include "platform/CrossOriginAttributeValue.h"
+#include "platform/loader/fetch/FetchParameters.h"
#include "platform/weborigin/Referrer.h"
#include "platform/wtf/Allocator.h"
@@ -46,7 +47,9 @@ class CSSImageSetValue : public CSSValueList {
StyleImage* CacheImage(
const Document&,
float device_scale_factor,
- CrossOriginAttributeValue = kCrossOriginAttributeNotSet);
+ CrossOriginAttributeValue = kCrossOriginAttributeNotSet,
+ FetchParameters::PlaceholderImageRequestType =
+ FetchParameters::kDisallowPlaceholder);
kouhei (in TOK) 2017/04/28 03:50:50 Option 1. [Preferred] Can we make this non-optiona
Raj 2017/04/28 18:01:21 Made it non-optional.
String CustomCSSText() const;

Powered by Google App Engine
This is Rietveld 408576698