third_party/WebKit/LayoutTests/fast/selectors/focus-within-display-none.html - Issue 2795143004: [selectors4] Implement :focus-within pseudo-class

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/selectors/focus-within-display-none.html

Issue 2795143004: [selectors4] Implement :focus-within pseudo-class (Closed)

Patch Set: Now passing all the tests from WPT Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <meta charset="utf-8">

	3 <script src=../../resources/testharness.js></script>

	4 <script src=../../resources/testharnessreport.js></script>

	5 <input id="input">

	6 <script>

	7 const input = document.getElementById("input");

	8 input.focus();

	9

	10 test(() => assert_true(input.matches(":focus")),

	11 "Check input mathces ':focus' after being focused");

	12 test(() => assert_true(input.matches(":focus-within")),

	13 "Check input mathces ':focus-within' after being focused");

	14

	15 input.style.display = "none";

	16 setTimeout(() => {

	17 test(() => assert_false(input.matches(":focus")),

	18 "Check input doesn't math ':focus' after getting 'display: none'");

	19 test(() => assert_flase(input.matches(":focus-within")),
	rune 2017/04/11 09:05:27 assert_flase? assert_flase?
	20 "Check input doesn't math ':focus-within' after getting 'display: none' ");

	21 }, 0);
	rune 2017/04/11 09:05:27 Are you sure this won't be flaky? This is because Are you sure this won't be flaky? This is because focus is cleared based on a 0-delayed timer triggered by ClearFocusedElementSoon()? rune 2017/04/11 09:15:10 Perhaps using rAF would be more correct? Also, sh Show quoted text On 2017/04/11 09:05:27, rune wrote: > Are you sure this won't be flaky? > > This is because focus is cleared based on a 0-delayed timer triggered by > ClearFocusedElementSoon()? Perhaps using rAF would be more correct? Also, shouldn't these tests be async?
	22 </script>

OLD	NEW