Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: third_party/WebKit/Source/web/SpellCheckerClientImpl.h

Issue 2795113002: Move ownership of TextCheckerClientImpl to WebLocalFrameImpl (Closed)
Patch Set: Rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/SpellCheckerClientImpl.h
diff --git a/third_party/WebKit/Source/web/SpellCheckerClientImpl.h b/third_party/WebKit/Source/web/SpellCheckerClientImpl.h
index e6adc9284a0ea16e5c61ca2e9ce67443d038d932..029e182e1bfa38f7355013cd4a991bc36ec209ed 100644
--- a/third_party/WebKit/Source/web/SpellCheckerClientImpl.h
+++ b/third_party/WebKit/Source/web/SpellCheckerClientImpl.h
@@ -35,14 +35,13 @@
namespace blink {
-class TextCheckerClient;
class WebViewImpl;
// TODO(xiaochengh): Split SpellCheckerClientImpl into two classes according to
// the split that should be done to its interface.
class SpellCheckerClientImpl final : public SpellCheckerClient {
public:
- explicit SpellCheckerClientImpl(WebViewImpl*, TextCheckerClient*);
+ explicit SpellCheckerClientImpl(WebViewImpl*);
~SpellCheckerClientImpl() override;
@@ -52,8 +51,6 @@ class SpellCheckerClientImpl final : public SpellCheckerClient {
void showSpellingUI(bool show) override;
bool spellingUIIsShowing() override;
- TextCheckerClient& textChecker() override { return *m_textCheckerClient; }
-
private:
// Returns whether or not the focused control needs spell-checking.
// Currently, this function just retrieves the focused node and determines
@@ -65,7 +62,6 @@ class SpellCheckerClientImpl final : public SpellCheckerClient {
bool shouldSpellcheckByDefault();
WebViewImpl* m_webView;
- TextCheckerClient* m_textCheckerClient;
// This flag is set to false if spell check for this editor is manually
// turned off. The default setting is SpellCheckAutomatic.
« no previous file with comments | « third_party/WebKit/Source/web/LocalFrameClientImpl.cpp ('k') | third_party/WebKit/Source/web/SpellCheckerClientImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698