Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Side by Side Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.h

Issue 2795113002: Move ownership of TextCheckerClientImpl to WebLocalFrameImpl (Closed)
Patch Set: Mon Apr 3 18:57:07 PDT 2017 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 48
49 #include <memory> 49 #include <memory>
50 50
51 namespace blink { 51 namespace blink {
52 52
53 class ChromePrintContext; 53 class ChromePrintContext;
54 class IntSize; 54 class IntSize;
55 class KURL; 55 class KURL;
56 class ScrollableArea; 56 class ScrollableArea;
57 class SharedWorkerRepositoryClientImpl; 57 class SharedWorkerRepositoryClientImpl;
58 class TextCheckerClient;
59 class TextCheckerClientImpl;
58 class TextFinder; 60 class TextFinder;
59 class WebAssociatedURLLoader; 61 class WebAssociatedURLLoader;
60 struct WebAssociatedURLLoaderOptions; 62 struct WebAssociatedURLLoaderOptions;
61 class WebAutofillClient; 63 class WebAutofillClient;
62 class WebDataSourceImpl; 64 class WebDataSourceImpl;
63 class WebDevToolsAgentImpl; 65 class WebDevToolsAgentImpl;
64 class WebDevToolsFrontendImpl; 66 class WebDevToolsFrontendImpl;
65 class WebFrameClient; 67 class WebFrameClient;
66 class WebInputMethodControllerImpl; 68 class WebInputMethodControllerImpl;
67 class WebNode; 69 class WebNode;
(...skipping 325 matching lines...) Expand 10 before | Expand all | Expand 10 after
393 return m_contentSettingsClient; 395 return m_contentSettingsClient;
394 } 396 }
395 SharedWorkerRepositoryClientImpl* sharedWorkerRepositoryClient() const { 397 SharedWorkerRepositoryClientImpl* sharedWorkerRepositoryClient() const {
396 return m_sharedWorkerRepositoryClient.get(); 398 return m_sharedWorkerRepositoryClient.get();
397 } 399 }
398 400
399 void setInputEventsTransformForEmulation(const IntSize&, float); 401 void setInputEventsTransformForEmulation(const IntSize&, float);
400 402
401 static void selectWordAroundPosition(LocalFrame*, VisiblePosition); 403 static void selectWordAroundPosition(LocalFrame*, VisiblePosition);
402 404
405 TextCheckerClient& textCheckerClient() const;
406
403 TextFinder* textFinder() const; 407 TextFinder* textFinder() const;
404 // Returns the text finder object if it already exists. 408 // Returns the text finder object if it already exists.
405 // Otherwise creates it and then returns. 409 // Otherwise creates it and then returns.
406 TextFinder& ensureTextFinder(); 410 TextFinder& ensureTextFinder();
407 411
408 // Returns a hit-tested VisiblePosition for the given point 412 // Returns a hit-tested VisiblePosition for the given point
409 VisiblePosition visiblePositionForViewportPoint(const WebPoint&); 413 VisiblePosition visiblePositionForViewportPoint(const WebPoint&);
410 414
411 void setFrameWidget(WebFrameWidgetBase*); 415 void setFrameWidget(WebFrameWidgetBase*);
412 416
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
490 // Borrowed pointers to Mojo objects. 494 // Borrowed pointers to Mojo objects.
491 blink::InterfaceProvider* m_interfaceProvider; 495 blink::InterfaceProvider* m_interfaceProvider;
492 blink::InterfaceRegistry* m_interfaceRegistry; 496 blink::InterfaceRegistry* m_interfaceRegistry;
493 497
494 WebDevToolsFrontendImpl* m_webDevToolsFrontend; 498 WebDevToolsFrontendImpl* m_webDevToolsFrontend;
495 499
496 Member<Node> m_contextMenuNode; 500 Member<Node> m_contextMenuNode;
497 501
498 std::unique_ptr<WebInputMethodControllerImpl> m_inputMethodController; 502 std::unique_ptr<WebInputMethodControllerImpl> m_inputMethodController;
499 503
504 // Stores the TextCheckerClient which communicates with SpellCheckProvider.
505 Member<TextCheckerClientImpl> m_textCheckerClient;
Xiaocheng 2017/04/04 02:03:21 Defined here.
506
500 // Oilpan: WebLocalFrameImpl must remain alive until close() is called. 507 // Oilpan: WebLocalFrameImpl must remain alive until close() is called.
501 // Accomplish that by keeping a self-referential Persistent<>. It is 508 // Accomplish that by keeping a self-referential Persistent<>. It is
502 // cleared upon close(). 509 // cleared upon close().
503 SelfKeepAlive<WebLocalFrameImpl> m_selfKeepAlive; 510 SelfKeepAlive<WebLocalFrameImpl> m_selfKeepAlive;
504 }; 511 };
505 512
506 DEFINE_TYPE_CASTS(WebLocalFrameImpl, 513 DEFINE_TYPE_CASTS(WebLocalFrameImpl,
507 WebFrame, 514 WebFrame,
508 frame, 515 frame,
509 frame->isWebLocalFrame(), 516 frame->isWebLocalFrame(),
510 frame.isWebLocalFrame()); 517 frame.isWebLocalFrame());
511 518
512 } // namespace blink 519 } // namespace blink
513 520
514 #endif 521 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698