Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Side by Side Diff: third_party/WebKit/Source/web/LocalFrameClientImpl.h

Issue 2795113002: Move ownership of TextCheckerClientImpl to WebLocalFrameImpl (Closed)
Patch Set: Mon Apr 3 18:57:07 PDT 2017 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2011 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
218 LinkResource* createServiceWorkerLinkResource(HTMLLinkElement*) override; 218 LinkResource* createServiceWorkerLinkResource(HTMLLinkElement*) override;
219 219
220 WebEffectiveConnectionType getEffectiveConnectionType() override; 220 WebEffectiveConnectionType getEffectiveConnectionType() override;
221 221
222 KURL overrideFlashEmbedWithHTML(const KURL&) override; 222 KURL overrideFlashEmbedWithHTML(const KURL&) override;
223 223
224 void setHasReceivedUserGesture() override; 224 void setHasReceivedUserGesture() override;
225 225
226 void abortClientNavigation() override; 226 void abortClientNavigation() override;
227 227
228 TextCheckerClient* textCheckerClient() const override;
Xiaocheng 2017/04/04 02:03:21 Is it the correct way to expose it to core?
229
228 private: 230 private:
229 explicit LocalFrameClientImpl(WebLocalFrameImpl*); 231 explicit LocalFrameClientImpl(WebLocalFrameImpl*);
230 232
231 bool isLocalFrameClientImpl() const override { return true; } 233 bool isLocalFrameClientImpl() const override { return true; }
232 WebDevToolsAgentImpl* devToolsAgent(); 234 WebDevToolsAgentImpl* devToolsAgent();
233 235
234 // The WebFrame that owns this object and manages its lifetime. Therefore, 236 // The WebFrame that owns this object and manages its lifetime. Therefore,
235 // the web frame object is guaranteed to exist. 237 // the web frame object is guaranteed to exist.
236 Member<WebLocalFrameImpl> m_webFrame; 238 Member<WebLocalFrameImpl> m_webFrame;
237 239
238 String m_userAgent; 240 String m_userAgent;
239 }; 241 };
240 242
241 DEFINE_TYPE_CASTS(LocalFrameClientImpl, 243 DEFINE_TYPE_CASTS(LocalFrameClientImpl,
242 LocalFrameClient, 244 LocalFrameClient,
243 client, 245 client,
244 client->isLocalFrameClientImpl(), 246 client->isLocalFrameClientImpl(),
245 client.isLocalFrameClientImpl()); 247 client.isLocalFrameClientImpl());
246 248
247 } // namespace blink 249 } // namespace blink
248 250
249 #endif 251 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698