Move ownership of TextCheckerClientImpl to WebLocalFrameImpl

third_party/WebKit/Source/core/loader/EmptyClients.h

 /*
  * Copyright (C) 2006 Eric Seidel (eric@webkit.org)
  * Copyright (C) 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  * Copyright (C) 2012 Samsung Electronics. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
@@ skipping 351 matching lines @@
   void willReleaseScriptContext(v8::Local<v8::Context>, int worldId) override {}
   bool allowScriptExtensions() override { return false; }
 
   WebCookieJar* cookieJar() const override { return 0; }
 
   std::unique_ptr<WebServiceWorkerProvider> createServiceWorkerProvider()
       override;
   std::unique_ptr<WebApplicationCacheHost> createApplicationCacheHost(
       WebApplicationCacheHostClient*) override;
 
+  TextCheckerClient* textCheckerClient() const override { return nullptr; }

[haraken, 2017/04/04 05:19:22]

Would it be possible to return an EmptyTextCheckerClient here instead of
creating it in SpellChecker.cpp?

+
  protected:
   EmptyLocalFrameClient() {}
 };
 
 class CORE_EXPORT EmptyTextCheckerClient : public TextCheckerClient {
-  DISALLOW_NEW();
+  WTF_MAKE_NONCOPYABLE(EmptyTextCheckerClient);
+  USING_FAST_MALLOC(EmptyTextCheckerClient);
 
  public:
-  ~EmptyTextCheckerClient() {}
+  EmptyTextCheckerClient() {}
 
   void checkSpellingOfString(const String&, int*, int*) override {}
   void requestCheckingOfString(TextCheckingRequest*) override;
   void cancelAllPendingRequests() override;
 };
 
 class EmptySpellCheckerClient : public SpellCheckerClient {
   WTF_MAKE_NONCOPYABLE(EmptySpellCheckerClient);
   USING_FAST_MALLOC(EmptySpellCheckerClient);
 
  public:
   EmptySpellCheckerClient() {}
   ~EmptySpellCheckerClient() override {}
 
   bool isSpellCheckingEnabled() override { return false; }
   void toggleSpellCheckingEnabled() override {}
-
-  TextCheckerClient& textChecker() override { return m_textCheckerClient; }
-
   void updateSpellingUIWithMisspelledWord(const String&) override {}
   void showSpellingUI(bool) override {}
   bool spellingUIIsShowing() override { return false; }
-
- private:
-  EmptyTextCheckerClient m_textCheckerClient;
 };
 
 class EmptyEditorClient final : public EditorClient {
   WTF_MAKE_NONCOPYABLE(EmptyEditorClient);
   USING_FAST_MALLOC(EmptyEditorClient);
 
  public:
   EmptyEditorClient() {}
   ~EmptyEditorClient() override {}
 
@@ skipping 53 matching lines @@
   Frame* nextSibling() const override { return nullptr; }
   Frame* firstChild() const override { return nullptr; }
   void frameFocused() const override {}
 };
 
 CORE_EXPORT void fillWithEmptyClients(Page::PageClients&);
 
 }  // namespace blink
 
 #endif  // EmptyClients_h