chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js - Issue 2795083003: Add support for in-page links in ChromeVox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js

Issue 2795083003: Add support for in-page links in ChromeVox. (Closed)

Patch Set: Address nit. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js

index fe87f8026ad4a47a50484650eaa79625ead8560d..9cc9cd73d552e55830c2a2046ce9a11c7f3f3739 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js

@@ -456,11 +456,17 @@ CommandHandler.onCommand = function(command) {

current = cursors.Range.fromNode(node);

break;

case 'forceClickOnCurrentItem':

- if (ChromeVoxState.instance.currentRange_) {

- var actionNode = ChromeVoxState.instance.currentRange_.start.node;

- if (actionNode.role == RoleType.INLINE_TEXT_BOX)

+ if (ChromeVoxState.instance.currentRange) {

+ var actionNode = ChromeVoxState.instance.currentRange.start.node;

+ while (actionNode.role == RoleType.INLINE_TEXT_BOX ||

+ actionNode.role == RoleType.STATIC_TEXT)

actionNode = actionNode.parent;

- actionNode.doDefault();

+ if (actionNode.inPageLinkTarget) {

+ ChromeVoxState.instance.navigateToRange(

+ cursors.Range.fromNode(actionNode.inPageLinkTarget));

+ } else {

+ actionNode.doDefault();

+ }

}

// Skip all other processing; if focus changes, we should get an event

// for that.