Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5514)

Unified Diff: chrome/browser/resources/chromeos/chromevox/common/dom_util.js

Issue 2795083003: Add support for in-page links in ChromeVox. (Closed)
Patch Set: Address nit. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/chromevox/common/dom_util.js
diff --git a/chrome/browser/resources/chromeos/chromevox/common/dom_util.js b/chrome/browser/resources/chromeos/chromevox/common/dom_util.js
index 827b062f30d98049aa1a419fc210cde12b52c8fd..c8d4fd69e689bf2c81eba748818bb7df26068555 100644
--- a/chrome/browser/resources/chromeos/chromevox/common/dom_util.js
+++ b/chrome/browser/resources/chromeos/chromevox/common/dom_util.js
@@ -746,14 +746,14 @@ cvox.DomUtil.getPrefixText = function(node, opt_index) {
opt_index == 0 &&
firstListitem.parentNode.tagName == 'OL' &&
node == leftmost &&
- document.defaultView.getComputedStyle(firstListitem.parentNode)
+ document.defaultView.getComputedStyle(firstListitem.parentElement)
.listStyleType != 'none') {
var items = cvox.DomUtil.toArray(firstListitem.parentNode.children).filter(
function(li) { return li.tagName == 'LI'; });
var position = items.indexOf(firstListitem) + 1;
// TODO(dtseng): Support all list style types.
if (document.defaultView.getComputedStyle(
- firstListitem.parentNode).listStyleType.indexOf('latin') != -1) {
+ firstListitem.parentElement).listStyleType.indexOf('latin') != -1) {
position--;
prefix = String.fromCharCode('A'.charCodeAt(0) + position % 26);
} else {
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698