Add support for parsing comments with generic parameters /*<K, V>*/ with Fasta.

Add support for parsing comments with generic parameters /*<K, V>*/ with Fasta.

R=paulberry@google.com, ahe@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/35d96bacabfdee3aa7e26c4f47dd5ba4047f90cc

[Paul Berry, 2017-04-03 22:31:21]

lgtm

[scheglov, 2017-04-03 23:27:53]

Description was changed from

==========
Add support for parsing comments with generic parameters /*<K, V>*/ with Fasta.

R=ahe@google.com, paulberry@google.com
BUG=
==========

to

==========
Add support for parsing comments with generic parameters /*<K, V>*/ with Fasta.

R=paulberry@google.com, ahe@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/35d96bacabfdee3aa7e26c4f47dd5ba4047f90cc
==========

[scheglov, 2017-04-03 23:27:54]

Committed patchset #1 (id:1) manually as
35d96bacabfdee3aa7e26c4f47dd5ba4047f90cc (presubmit successful).

[ahe, 2017-04-04 08:10:45]

https://codereview.chromium.org/2795063002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/parser.dart (right):

https://codereview.chromium.org/2795063002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:120: import
'../scanner/string_scanner.dart';
The parser shouldn't be importing as specific scanner.

https://codereview.chromium.org/2795063002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:643: token =
_injectGenericCommentTypeList(token);
This method should be public and overridden in a subclass.

https://codereview.chromium.org/2795063002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:1118: /// TODO(ahe): Clean this
up.
This isn't a documentation comment.

https://codereview.chromium.org/2795063002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:3838: var scanner = new
StringScanner(' ' * offset + code);
The listener should be asked how to create a scanner, otherwise you can't extend
it.

[scheglov, 2017-04-04 15:33:48]

https://codereview.chromium.org/2795063002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/parser.dart (right):

https://codereview.chromium.org/2795063002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:120: import
'../scanner/string_scanner.dart';
On 2017/04/04 08:10:45, ahe wrote:
> The parser shouldn't be importing as specific scanner.

Why?
The parser knows what it wants to parse and how.

https://codereview.chromium.org/2795063002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:643: token =
_injectGenericCommentTypeList(token);
On 2017/04/04 08:10:45, ahe wrote:
> This method should be public and overridden in a subclass.

In which subclass?

https://codereview.chromium.org/2795063002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:1118: /// TODO(ahe): Clean this
up.
On 2017/04/04 08:10:45, ahe wrote:
> This isn't a documentation comment.

Well, I think any comment before a method, and which is related to the method,
should be a documentation comment.

https://codereview.chromium.org/2795063002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:3838: var scanner = new
StringScanner(' ' * offset + code);
On 2017/04/04 08:10:45, ahe wrote:
> The listener should be asked how to create a scanner, otherwise you can't
extend
> it.

What do we want to extend?
These comments are part of the language, and should be supported in the parser
for the language.

[ahe, 2017-04-05 14:43:53]

Konstantin,

I've realized that there's a lack of documentation about the parser's design.
Based on this conversation, I'll try to get started on a document where I
explain the detailed reasoning behind this. I hope you'll help me by being one
of the first reviewers.

On 2017/04/04 15:33:48, scheglov wrote:
>
https://codereview.chromium.org/2795063002/diff/1/pkg/front_end/lib/src/fasta...
> File pkg/front_end/lib/src/fasta/parser/parser.dart (right):
> 
>
https://codereview.chromium.org/2795063002/diff/1/pkg/front_end/lib/src/fasta...
> pkg/front_end/lib/src/fasta/parser/parser.dart:120: import
> '../scanner/string_scanner.dart';
> On 2017/04/04 08:10:45, ahe wrote:
> > The parser shouldn't be importing as specific scanner.
> 
> Why?
> The parser knows what it wants to parse and how.
> 
>
https://codereview.chromium.org/2795063002/diff/1/pkg/front_end/lib/src/fasta...
> pkg/front_end/lib/src/fasta/parser/parser.dart:643: token =
> _injectGenericCommentTypeList(token);
> On 2017/04/04 08:10:45, ahe wrote:
> > This method should be public and overridden in a subclass.
> 
> In which subclass?
> 
>
https://codereview.chromium.org/2795063002/diff/1/pkg/front_end/lib/src/fasta...
> pkg/front_end/lib/src/fasta/parser/parser.dart:1118: /// TODO(ahe): Clean this
> up.
> On 2017/04/04 08:10:45, ahe wrote:
> > This isn't a documentation comment.
> 
> Well, I think any comment before a method, and which is related to the method,
> should be a documentation comment.
> 
>
https://codereview.chromium.org/2795063002/diff/1/pkg/front_end/lib/src/fasta...
> pkg/front_end/lib/src/fasta/parser/parser.dart:3838: var scanner = new
> StringScanner(' ' * offset + code);
> On 2017/04/04 08:10:45, ahe wrote:
> > The listener should be asked how to create a scanner, otherwise you can't
> extend
> > it.
> 
> What do we want to extend?
> These comments are part of the language, and should be supported in the parser
> for the language.