components/subresource_filter/content/browser/subresource_filter_client.h - Issue 2795053002: [subresource_filter] Implement the "Smart" UI on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/browser/subresource_filter_client.h

Issue 2795053002: [subresource_filter] Implement the "Smart" UI on Android (Closed)

Patch Set: fix tests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/subresource_filter/chrome_subresource_filter_client.cc ('K') | « components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/browser/subresource_filter_client.h

diff --git a/components/subresource_filter/content/browser/subresource_filter_client.h b/components/subresource_filter/content/browser/subresource_filter_client.h

index c9beae7f6556998b3d120ac1da523d2cee744b14..000d824ade02a174484eb9975867f7c852456da0 100644

--- a/components/subresource_filter/content/browser/subresource_filter_client.h

+++ b/components/subresource_filter/content/browser/subresource_filter_client.h

@@ -19,7 +19,8 @@ class SubresourceFilterClient {

// right side of the omnibox is displayed. If the user clicks on the icon then

// a bubble is shown that explains the feature and alalows the user to turn it

// off.

- virtual void ToggleNotificationVisibility(bool visibility) = 0;

+ virtual void ToggleNotificationVisibility(const GURL& url,

+ bool visibility) = 0;

// Returns true if the given URL is whitelisted from activation via content

// settings. This should only be called for main frame URLs.