components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc - Issue 2795053002: [subresource_filter] Implement the "Smart" UI on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc

Issue 2795053002: [subresource_filter] Implement the "Smart" UI on Android (Closed)

Patch Set: fix tests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/subresource_filter/chrome_subresource_filter_client.cc ('K') | « components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h ('k') | components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc

diff --git a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc

index 410b37382d6f5b76f56cd82d171adc47089cce45..b49581e29de78f1f889d11918d98432bf99e9cd1 100644

--- a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc

+++ b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc

@@ -101,8 +101,8 @@ void ContentSubresourceFilterDriverFactory::OnFirstSubresourceLoadDisallowed() {

if (ShouldSuppressNotifications())

return;

- client_->ToggleNotificationVisibility(activation_level_ ==

- ActivationLevel::ENABLED);

+ client_->ToggleNotificationVisibility(

+ navigation_chain_.back(), activation_level_ == ActivationLevel::ENABLED);

}

void ContentSubresourceFilterDriverFactory::OnDocumentLoadStatistics(

@@ -226,7 +226,7 @@ void ContentSubresourceFilterDriverFactory::DidStartNavigation(

activation_decision_ = ActivationDecision::UNKNOWN;

ResetActivationState();

navigation_chain_.push_back(navigation_handle->GetURL());

- client_->ToggleNotificationVisibility(false);

+ client_->ToggleNotificationVisibility(navigation_handle->GetURL(), false);

}