Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3234)

Unified Diff: chrome/browser/subresource_filter/chrome_subresource_filter_client.h

Issue 2795053002: [subresource_filter] Implement the "Smart" UI on Android (Closed)
Patch Set: rebase on #468985 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/subresource_filter/chrome_subresource_filter_client.h
diff --git a/chrome/browser/subresource_filter/chrome_subresource_filter_client.h b/chrome/browser/subresource_filter/chrome_subresource_filter_client.h
index 73649c90a5eb0030fb25cfa04a91aa07fa24d260..4a8a83f686802e54e0e08595abd6257b18ff936a 100644
--- a/chrome/browser/subresource_filter/chrome_subresource_filter_client.h
+++ b/chrome/browser/subresource_filter/chrome_subresource_filter_client.h
@@ -13,6 +13,7 @@
#include "components/subresource_filter/content/browser/subresource_filter_client.h"
class GURL;
+class SubresourceFilterContentSettingsManager;
namespace content {
class NavigationHandle;
@@ -41,7 +42,8 @@ enum SubresourceFilterAction {
// Content setting updated automatically via the standard UI.
kActionContentSettingsBlockedFromUI,
- // Content settings which target specific origins (e.g. no wildcards).
+ // Content settings which target specific origins (e.g. no wildcards). These
+ // updates do not include updates from the main UI.
kActionContentSettingsAllowed,
kActionContentSettingsBlocked,
@@ -57,6 +59,16 @@ enum SubresourceFilterAction {
// flexible.
kActionContentSettingsWildcardUpdate,
+ // The UI was suppressed due to "smart" logic which tries not to spam the UI
+ // on navigations on the same origin within a certain time.
+ kActionUISuppressed,
+
+ // The feature was blocked via content setting manually while smart UI was
+ // suppressing the UI. Potentially indicates that the smart UI is too
+ // aggressive if this happens frequently. This is a reported alongside
+ // kActionContentSettingsBlocked if the UI is currently in suppressed mode.
+ kActionContentSettingsBlockedWhileUISuppressed,
+
kActionLastEntry
};
@@ -83,8 +95,11 @@ class ChromeSubresourceFilterClient
static void LogAction(SubresourceFilterAction action);
private:
- ContentSetting GetContentSettingForUrl(const GURL& url);
std::set<std::string> whitelisted_hosts_;
+
+ // Owned by the profile.
+ SubresourceFilterContentSettingsManager* settings_manager_;
+
content::WebContents* web_contents_;
bool did_show_ui_for_navigation_;

Powered by Google App Engine
This is Rietveld 408576698