Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: components/content_settings/core/common/content_settings_types.h

Issue 2795053002: [subresource_filter] Implement the "Smart" UI on Android (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/content_settings/core/common/content_settings_types.h
diff --git a/components/content_settings/core/common/content_settings_types.h b/components/content_settings/core/common/content_settings_types.h
index d7584141be5b3c85efbc0a95535a443f41fa0b0b..3c31cde2ea03c9f91a05a045a72907f4a518eaa1 100644
--- a/components/content_settings/core/common/content_settings_types.h
+++ b/components/content_settings/core/common/content_settings_types.h
@@ -50,6 +50,11 @@ enum ContentSettingsType {
CONTENT_SETTINGS_TYPE_PERMISSION_AUTOBLOCKER_DATA,
CONTENT_SETTINGS_TYPE_SUBRESOURCE_FILTER,
+ // Website setting which stores metadata for the subresource filter to aid in
+ // decisions for whether or not to show the UI. Currently only used on
+ // Android.
Charlie Harrison 2017/04/26 16:33:23 raymes: We could re-use this website setting to im
msramek 2017/05/08 16:40:26 This wasn't addressed to me, I just want to +1 reu
Charlie Harrison 2017/05/08 20:57:21 I don't even think we need to add another key, we
+ CONTENT_SETTINGS_TYPE_SUBRESOURCE_FILTER_DATA,
+
// This is special-cased in the permissions layer to always allow, and as
// such doesn't have associated prefs data.
CONTENT_SETTINGS_TYPE_MIDI,

Powered by Google App Engine
This is Rietveld 408576698