components/content_settings/core/common/content_settings.cc - Issue 2795053002: [subresource_filter] Implement the "Smart" UI on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/common/content_settings.cc

Issue 2795053002: [subresource_filter] Implement the "Smart" UI on Android (Closed)

Patch Set: raymes review Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/content_settings/core/common/content_settings.cc

diff --git a/components/content_settings/core/common/content_settings.cc b/components/content_settings/core/common/content_settings.cc

index ec1621532d923046acf5d916aaf72ed060168235..472c493eef8ee67d774c3f012f1f801e0d299e6f 100644

--- a/components/content_settings/core/common/content_settings.cc

+++ b/components/content_settings/core/common/content_settings.cc

@@ -22,6 +22,8 @@ ContentSetting IntToContentSetting(int content_setting) {

// ContentType enum in histograms.xml.

// TODO(raymes): We should use a sparse histogram here on the hash of the

// content settings type name instead.

+// TODO(raymes): This has become out of sync with histograms.xml. See

+// crbug.com/697234.

ContentSettingsType kHistogramOrder[] = {

CONTENT_SETTINGS_TYPE_COOKIES,

CONTENT_SETTINGS_TYPE_IMAGES,