Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 279483002: Remove blink-reviews-bindings members from 'bindings' WATCHLISTS (Closed)

Created:
6 years, 7 months ago by Nils Barth (inactive)
Modified:
6 years, 7 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Visibility:
Public.

Description

Remove blink-reviews-bindings members from 'bindings' WATCHLISTS Batch update to remove people who've moved to the mailing list: https://groups.google.com/a/chromium.org/forum/#!members/blink-reviews-bindings Also remove outdated comment in Source/bindings/OWNERS to Source/OWNERS (no longer exists, as the per-file rules didn't work). R=haraken NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173602

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M Source/bindings/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M WATCHLISTS View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Nils Barth (inactive)
WATCHLISTS update
6 years, 7 months ago (2014-05-08 04:06:38 UTC) #1
haraken
LGTM, though I'm actually not happy about the change for a strange reason: Due to ...
6 years, 7 months ago (2014-05-08 04:17:27 UTC) #2
Nils Barth (inactive)
On 2014/05/08 04:17:27, haraken wrote: > LGTM, though I'm actually not happy about the change ...
6 years, 7 months ago (2014-05-08 04:34:29 UTC) #3
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 7 months ago (2014-05-08 04:56:10 UTC) #4
Nils Barth (inactive)
The CQ bit was unchecked by nbarth@chromium.org
6 years, 7 months ago (2014-05-08 04:56:12 UTC) #5
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 7 months ago (2014-05-08 04:56:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/279483002/1
6 years, 7 months ago (2014-05-08 04:57:01 UTC) #7
commit-bot: I haz the power
Change committed as 173602
6 years, 7 months ago (2014-05-08 04:57:27 UTC) #8
Nils Barth (inactive)
6 years, 7 months ago (2014-05-08 04:58:13 UTC) #9
Message was sent while issue was closed.
On 2014/05/08 04:34:29, Nils Barth wrote:
> On 2014/05/08 04:17:27, haraken wrote:
> > LGTM, though I'm actually not happy about the change for a strange reason:
> > 
> > Due to the poor UI of the code review tool, it sometimes happens (once per
> > week?) that someone accidentally removes my name from the cc list. Having
both
> > haraken@ and blink-reviews-bindings@ decreases the risk.
> 
> I think this will reduce this problem significantly:
> we'll now have a much shorter list (ideally just 2 addresses or so),
> and thus it'll be clear if blink-reviews-bindings is present or not.
> ...and if someone removes blink-reviews-bindings, it'll be quite clear
> that no-one's replying.

Actually, I just checked the CC list for this issue itself, and it starts with:
blink-reviews@chromium.org, blink-reviews-bindings@chromium.org,
...which are exactly what are visible for me, so it's very clear if these are
missing.

Powered by Google App Engine
This is Rietveld 408576698