Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7639)

Unified Diff: chrome/browser/ui/sad_tab.h

Issue 2794763002: New Sad Tab strings. (Closed)
Patch Set: right number of spaces as per UI review Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/sad_tab.cc » ('j') | chrome/browser/ui/sad_tab.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/sad_tab.h
diff --git a/chrome/browser/ui/sad_tab.h b/chrome/browser/ui/sad_tab.h
index 28698d0a78a3ef905a2c0602796a6f670d4fc728..42c14b386e3cfc41d3a78ce16ea04db1abd87d56 100644
--- a/chrome/browser/ui/sad_tab.h
+++ b/chrome/browser/ui/sad_tab.h
@@ -38,6 +38,10 @@ class SadTab {
int GetButtonTitle();
int GetHelpLinkTitle();
+ // Returns the resource string Id for bullet point |bullet_id| or 0 if no
+ // bullet should be added for the |bullet_id|. Bullet ids count from 0.
+ int GetBulletText(size_t bullet_id);
sky 2017/05/14 13:46:16 optional: consider naming this Submessage. While t
Will Harris 2017/05/17 18:25:19 Done.
+
// Returns the target of the "Learn more" link. Use it for the context menu
// and to show the URL on hover, but call PerformAction() for regular clicks.
const char* GetHelpLinkURL();
@@ -54,6 +58,7 @@ class SadTab {
SadTabKind kind_;
bool show_feedback_button_;
bool recorded_paint_;
+ bool other_tabs_open_;
sky 2017/05/14 13:46:16 Please add description. AFAICT this is always true
Will Harris 2017/05/17 18:25:19 I removed this and now actually detect other tabs
DISALLOW_COPY_AND_ASSIGN(SadTab);
};
« no previous file with comments | « no previous file | chrome/browser/ui/sad_tab.cc » ('j') | chrome/browser/ui/sad_tab.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698