OLD | NEW |
1 # Adding third_party Libraries | 1 # Adding third_party Libraries |
2 | 2 |
3 [TOC] | 3 [TOC] |
4 | 4 |
5 Using third party code can save time and is consistent with our values - no need | 5 Using third party code can save time and is consistent with our values - no need |
6 to reinvent the wheel! We put all code that isn't written by Chromium developers | 6 to reinvent the wheel! We put all code that isn't written by Chromium developers |
7 into src/third_party (even if you end up modifying just a few functions). We do | 7 into src/third_party (even if you end up modifying just a few functions). We do |
8 this to make it easy to track license compliance, security patches, and supply | 8 this to make it easy to track license compliance, security patches, and supply |
9 the right credit and attributions. It also makes it a lot easier for other | 9 the right credit and attributions. It also makes it a lot easier for other |
10 projects that embed our code to track what is Chromium licensed and what is | 10 projects that embed our code to track what is Chromium licensed and what is |
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
58 ### Add a LICENSE file and run related checks | 58 ### Add a LICENSE file and run related checks |
59 | 59 |
60 You need a LICENSE file. Example: | 60 You need a LICENSE file. Example: |
61 [third_party/libjpeg/LICENSE](http://src.chromium.org/viewvc/chrome/trunk/src/th
ird_party/libjpeg/LICENSE?revision=42288&view=markup). | 61 [third_party/libjpeg/LICENSE](http://src.chromium.org/viewvc/chrome/trunk/src/th
ird_party/libjpeg/LICENSE?revision=42288&view=markup). |
62 | 62 |
63 Run the following scripts: | 63 Run the following scripts: |
64 | 64 |
65 * `src/tools/licenses.py scan` - This will complain about incomplete or missing | 65 * `src/tools/licenses.py scan` - This will complain about incomplete or missing |
66 data for third_party checkins. We use 'licenses.py credits' to generate the | 66 data for third_party checkins. We use 'licenses.py credits' to generate the |
67 about:credits page in Google Chrome builds. | 67 about:credits page in Google Chrome builds. |
68 * `src/tools/checklicenses/checklicenses.py` - See below for info how to handle | 68 * `src/tools/checklicenses/checklicenses.py` - See below for info on how to |
69 possible failures. | 69 handle possible failures. |
70 * If you are adding code that will be present in the content layer, please make | 70 * If you are adding code that will be present in the content layer, please make |
71 sure that the license used is compliant with Android tree requirements because | 71 sure that the license used is compliant with Android tree requirements because |
72 this code will also be used in Android WebView. You need to run | 72 this code will also be used in Android WebView. You need to run |
73 `src/android_webview/tools/webview_licenses.py scan` | 73 `src/android_webview/tools/webview_licenses.py scan` |
74 | 74 |
75 See the ["Odds n' Ends"](adding_to_third_party.md#Odds-n_Ends) Section below if | 75 See the ["Odds n' Ends"](adding_to_third_party.md#Odds-n_Ends) Section below if |
76 you run into any failures running these. | 76 you run into any failures running these. |
77 | 77 |
78 If the library will never be shipped as a part of Chrome (e.g. build-time tools, | 78 If the library will never be shipped as a part of Chrome (e.g. build-time tools, |
79 testing tools), make sure to set "License File" as "NOT_SHIPPED" so that the | 79 testing tools), make sure to set "License File" as "NOT_SHIPPED" so that the |
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
193 | 193 |
194 * Missing license file | 194 * Missing license file |
195 * Make sure that the license file is present. It should be called 'LICENSE', | 195 * Make sure that the license file is present. It should be called 'LICENSE', |
196 or otherwise README.chromium file must point to it explicitly. | 196 or otherwise README.chromium file must point to it explicitly. |
197 * The following files contain a third-party license but are not in a listed | 197 * The following files contain a third-party license but are not in a listed |
198 third-party directory... | 198 third-party directory... |
199 * Check if it's a false positive (e.g. 'copyright' word used in a string | 199 * Check if it's a false positive (e.g. 'copyright' word used in a string |
200 literal), if so, update | 200 literal), if so, update |
201 [src/tools/copyright_scanner/third_party_files_whitelist.txt](https://code
.google.com/p/chromium/codesearch#chromium/src/tools/copyright_scanner/third_par
ty_files_whitelist.txt) | 201 [src/tools/copyright_scanner/third_party_files_whitelist.txt](https://code
.google.com/p/chromium/codesearch#chromium/src/tools/copyright_scanner/third_par
ty_files_whitelist.txt) |
202 file. Otherwise, please move the code into third_party. | 202 file. Otherwise, please move the code into third_party. |
OLD | NEW |