Fix inline outline in a corner case

third_party/WebKit/Source/core/layout/LayoutBlock.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc.
  *               All rights reserved.
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 458 matching lines @@
   if (childrenInline())
     toLayoutBlockFlow(this)->addOverflowFromInlineChildren();
   else
     addOverflowFromBlockChildren();
 }
 
 DISABLE_CFI_PERF
 void LayoutBlock::computeOverflow(LayoutUnit oldClientAfterEdge, bool) {
   m_overflow.reset();
 
-  // Add overflow from children.
   addOverflowFromChildren();
-
-  // Add in the overflow from positioned objects.
   addOverflowFromPositionedObjects();
 
   if (hasOverflowClip()) {
     // When we have overflow clip, propagate the original spillout since it will
     // include collapsed bottom margins and bottom padding. Set the axis we
     // don't care about to be 1, since we want this overflow to always be
     // considered reachable.
     LayoutRect clientRect(noOverflowRect());
     LayoutRect rectToApply;
     if (isHorizontalWritingMode())
@@ skipping 17 matching lines @@
   // overflow it.
   PaintLayer* layer = enclosingLayer();
   if (!needsLayout() && layer->hasCompositedLayerMapping() &&
       !layer->visualRect().contains(visualOverflowRect()))
     layer->setNeedsCompositingInputsUpdate();
 }
 
 void LayoutBlock::addOverflowFromBlockChildren() {
   for (LayoutBox* child = firstChildBox(); child;
        child = child->nextSiblingBox()) {
-    if (!child->isFloatingOrOutOfFlowPositioned() && !child->isColumnSpanAll())
-      addOverflowFromChild(child);
+    if (child->isFloatingOrOutOfFlowPositioned() || child->isColumnSpanAll())
+      continue;
+
+    // If the child contains inline with outline and continuation, its
+    // visual overflow computed during its layout might be inaccurate because
+    // the layout of continuations might not be up-to-date at that time.
+    // Re-add overflow from inline children to ensure its overflow covers
+    // the outline which may enclose continuations.
+    if (child->isLayoutBlockFlow() &&
+        toLayoutBlockFlow(child)->containsInlineWithOutlineAndContinuation())
+      toLayoutBlockFlow(child)->addOverflowFromInlineChildren();
+
+    addOverflowFromChild(child);
   }
 }
 
 void LayoutBlock::addOverflowFromPositionedObjects() {
   TrackedLayoutBoxListHashSet* positionedDescendants = positionedObjects();
   if (!positionedDescendants)
     return;
 
   for (auto* positionedObject : *positionedDescendants) {
     // Fixed positioned elements don't contribute to layout overflow, since they
@@ skipping 1634 matching lines @@
   }
 
   return availableHeight;
 }
 
 bool LayoutBlock::hasDefiniteLogicalHeight() const {
   return availableLogicalHeightForPercentageComputation() != LayoutUnit(-1);
 }
 
 }  // namespace blink