Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: pkg/analyzer/lib/src/dart/scanner/scanner.dart

Issue 2794653002: fasta tokens implement analyzer token API (Closed)
Patch Set: merge Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/dart/ast/token.dart ('k') | pkg/analyzer/lib/src/fasta/token_utils.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/dart/scanner/scanner.dart
diff --git a/pkg/analyzer/lib/src/dart/scanner/scanner.dart b/pkg/analyzer/lib/src/dart/scanner/scanner.dart
index 821768723e95b5591c59c404527129a734404a7f..316c82762ae22d22e93a40557dc3d97909e69f00 100644
--- a/pkg/analyzer/lib/src/dart/scanner/scanner.dart
+++ b/pkg/analyzer/lib/src/dart/scanner/scanner.dart
@@ -10,6 +10,8 @@ import 'package:analyzer/src/dart/error/syntactic_errors.dart';
import 'package:analyzer/src/dart/scanner/reader.dart';
import 'package:analyzer/src/generated/source.dart';
import 'package:front_end/src/fasta/scanner.dart' as fasta;
+import 'package:front_end/src/fasta/scanner/abstract_scanner.dart'
+ show fastaSupportsGenericMethodComments;
import 'package:front_end/src/fasta/scanner/precedence.dart' as fasta;
import 'package:front_end/src/scanner/errors.dart' show translateErrorToken;
import 'package:front_end/src/scanner/scanner.dart' as fe;
@@ -41,12 +43,6 @@ class Scanner extends fe.Scanner {
final AnalysisErrorListener _errorListener;
/**
- * A flag indicating whether the [Scanner] factory method
- * will return a fasta based scanner or an analyzer based scanner.
- */
- static bool useFasta = false;
-
- /**
* Initialize a newly created scanner to scan characters from the given
* [source]. The given character [reader] will be used to read the characters
* in the source. The given [_errorListener] will be informed of any errors
@@ -54,7 +50,7 @@ class Scanner extends fe.Scanner {
*/
factory Scanner(Source source, CharacterReader reader,
AnalysisErrorListener errorListener) =>
- useFasta
+ fe.Scanner.useFasta
? new _Scanner2(source, reader.getContents(), errorListener)
: new Scanner._(source, reader, errorListener);
@@ -93,7 +89,7 @@ class _Scanner2 implements Scanner {
bool _preserveComments = true;
@override
- List<int> lineStarts;
+ final List<int> lineStarts = <int>[];
@override
Token firstToken;
@@ -104,7 +100,9 @@ class _Scanner2 implements Scanner {
@override
bool scanLazyAssignmentOperators = false;
- _Scanner2(this.source, this._contents, this._errorListener);
+ _Scanner2(this.source, this._contents, this._errorListener) {
+ lineStarts.add(0);
+ }
@override
void appendToken(Token token) {
@@ -155,7 +153,8 @@ class _Scanner2 implements Scanner {
fasta.ScannerResult result =
fasta.scanString(_contents, includeComments: _preserveComments);
// fasta pretends there is an additional line at EOF
- lineStarts = result.lineStarts.sublist(0, result.lineStarts.length - 1);
+ lineStarts
+ .addAll(result.lineStarts.sublist(1, result.lineStarts.length - 1));
fasta.Token token = result.tokens;
// The default recovery strategy used by scanString
// places all error tokens at the head of the stream.
« no previous file with comments | « pkg/analyzer/lib/src/dart/ast/token.dart ('k') | pkg/analyzer/lib/src/fasta/token_utils.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698