fasta tokens implement analyzer token API

fasta tokens implement analyzer token API

* finish making fasta tokens implement analyzer token API

* move a couple things from analyzer into front_end
   * Scanner useFasta flag
   * SyntheticKeywordToken
   * SyntheticStringToken

* add a fastaSupportsGenericMethodComments flag to more easily find
  all of the places in the code that need to be addressed
  when this functionality is added or dropped

* initialize linestarts in scanner adapter
* cleanup analyzer hints

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/75a608b7611abb29e7c3c71593d7a8a536bb64df

[danrubel, 2017-03-31 20:14:31]

danrubel@google.com changed reviewers:
+ ahe@google.com, brianwilkerson@google.com

[Brian Wilkerson, 2017-03-31 20:39:05]

lgtm

https://codereview.chromium.org/2794653002/diff/1/pkg/analyzer/lib/src/dart/s...
File pkg/analyzer/lib/src/dart/scanner/scanner.dart (right):

https://codereview.chromium.org/2794653002/diff/1/pkg/analyzer/lib/src/dart/s...
pkg/analyzer/lib/src/dart/scanner/scanner.dart:92: final List<int> lineStarts =
new List<int>();
nit: "<int>[]" is shorter.

[danrubel, 2017-04-04 12:45:41]

https://codereview.chromium.org/2794653002/diff/1/pkg/analyzer/lib/src/dart/s...
File pkg/analyzer/lib/src/dart/scanner/scanner.dart (right):

https://codereview.chromium.org/2794653002/diff/1/pkg/analyzer/lib/src/dart/s...
pkg/analyzer/lib/src/dart/scanner/scanner.dart:92: final List<int> lineStarts =
new List<int>();
On 2017/03/31 20:39:05, Brian Wilkerson wrote:
> nit: "<int>[]" is shorter.

Good idea. Done.

[danrubel, 2017-04-04 12:55:50]

Description was changed from

==========
fasta tokens implement analyzer token API

* finish making fasta tokens implement analyzer token API

* move a couple things from analyzer into front_end
   * Scanner useFasta flag
   * SyntheticKeywordToken
   * SyntheticStringToken

* add a fastaSupportsGenericMethodComments flag to more easily find
  all of the places in the code that need to be addressed
  when this functionality is added or dropped

* initialize linestarts in scanner adapter
* cleanup analyzer hints
==========

to

==========
fasta tokens implement analyzer token API

* finish making fasta tokens implement analyzer token API

* move a couple things from analyzer into front_end
   * Scanner useFasta flag
   * SyntheticKeywordToken
   * SyntheticStringToken

* add a fastaSupportsGenericMethodComments flag to more easily find
  all of the places in the code that need to be addressed
  when this functionality is added or dropped

* initialize linestarts in scanner adapter
* cleanup analyzer hints

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/75a608b7611abb29e7c3c71593d7a8a536bb64df
==========

[danrubel, 2017-04-04 12:55:51]

Committed patchset #3 (id:40001) manually as
75a608b7611abb29e7c3c71593d7a8a536bb64df (presubmit successful).