Issue 2794583002: Revert "Reland "VM: Handle null-comparisons in the flow graph type propagation""

Issue 2794583002: Revert "Reland "VM: Handle null-comparisons in the flow graph type propagation"" (Closed)

Created:
3 years, 8 months ago by Florian Schneider

Modified:
3 years, 8 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Reland "VM: Handle null-comparisons in the flow graph type propagation"" This reverts commit e7afde47e9afc981e9609ea14770debc18479bb1. This was because of analyzer test failures (out of memory in the background compiler) TBR=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/ee452a8600f393d892fa482e60bac2af27bff0ae

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+181 lines, -304 lines)			Patch
M	runtime/lib/integers.dart	View	3 chunks	+2 lines, -6 lines	0 comments	Download
M	runtime/vm/flow_graph.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_type_propagator.cc	View	4 chunks	+10 lines, -28 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	138 chunks	+160 lines, -152 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/intrinsifier.cc	View	3 chunks	+2 lines, -16 lines	0 comments	Download
M	runtime/vm/object.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	runtime/vm/object.cc	View	3 chunks	+0 lines, -20 lines	0 comments	Download
M	runtime/vm/object_store.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	runtime/vm/object_store.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/symbols.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	tests/language/vm/integer_type_propagation2_test.dart	View	1 chunk	+0 lines, -36 lines	0 comments	Download
D	tests/language/vm/integer_type_propagation_test.dart	View	1 chunk	+0 lines, -27 lines	0 comments	Download

Total messages: 3 (1 generated)

Florian Schneider

3 years, 8 months ago (2017-03-31 17:54:04 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ee452a8600f393d892fa482e60bac2af27bff0ae (presubmit successful).