Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2794503002: Fix static typing problem in analysis_server tests. (Closed)

Created:
3 years, 8 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org, Brian Wilkerson
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix static typing problem in analysis_server tests. After changing argument of `Future` constructor to be `()->FutureOr<T>`, the `()->Future<dynamic>` argument didn't work. Problem compounded by return type of `Stream<T>.firstWhere` being `dynamic`. R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/83298690b00680a15dc37ccdd4e1fdd79d4c9c33

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M pkg/analysis_server/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/mocks.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Lasse Reichstein Nielsen
3 years, 8 months ago (2017-03-31 12:02:12 UTC) #2
karlklose
LGTM
3 years, 8 months ago (2017-03-31 12:05:15 UTC) #3
Lasse Reichstein Nielsen
Committed patchset #1 (id:1) manually as 83298690b00680a15dc37ccdd4e1fdd79d4c9c33 (presubmit successful).
3 years, 8 months ago (2017-03-31 12:12:38 UTC) #5
Brian Wilkerson
3 years, 8 months ago (2017-03-31 13:41:33 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698