Add AuthPolicyLoginHelper

chromeos/dbus/fake_auth_policy_client_unittest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/dbus/fake_auth_policy_client.h"
 
 #include "base/bind.h"
+#include "base/message_loop/message_loop.h"
+#include "base/run_loop.h"
 #include "components/signin/core/account_id/account_id.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace chromeos {
 namespace {
 
 const char kCorrectMachineName[] = "machine_name";
 const char kCorrectUserName[] = "user@realm.com";
 
 }  // namespace
 
+class FakeAuthPolicyClientTest : public ::testing::Test {
+ protected:
+  FakeAuthPolicyClient client;

[xiyuan, 2017/04/07 15:04:24]

client -> client_

And I would prefer to put this in private and add a getter for it.

[Roman Sorokin (ftl), 2017/04/10 16:09:00]

Done.

+
+ private:
+  base::MessageLoop loop;

[xiyuan, 2017/04/07 15:04:24]

loop -> loop_

[Roman Sorokin (ftl), 2017/04/10 16:09:00]

Done.

+};

[xiyuan, 2017/04/07 15:04:24]

nit: DISALLOW_COPY_AND_ASSIGN

[Roman Sorokin (ftl), 2017/04/10 16:09:00]

Done.

+
 // Tests parsing machine name.
-TEST(FakeAuthPolicyClientTest, JoinAdDomain_ParseMachineName) {
-  FakeAuthPolicyClient client;
+TEST_F(FakeAuthPolicyClientTest, JoinAdDomain_ParseMachineName) {
   client.set_started(true);
   client.JoinAdDomain("correct_length1", kCorrectUserName, /* password_fd */ -1,
                       base::Bind([](authpolicy::ErrorType error) {
                         EXPECT_EQ(authpolicy::ERROR_NONE, error);
                       }));
   client.JoinAdDomain("", kCorrectUserName, /* password_fd */ -1,
                       base::Bind([](authpolicy::ErrorType error) {
                         EXPECT_EQ(authpolicy::ERROR_BAD_MACHINE_NAME, error);
                       }));
   client.JoinAdDomain(
       "too_long_machine_name", kCorrectUserName, /* password_fd */ -1,
       base::Bind([](authpolicy::ErrorType error) {
         EXPECT_EQ(authpolicy::ERROR_MACHINE_NAME_TOO_LONG, error);
       }));
   client.JoinAdDomain("invalid:name", kCorrectUserName, /* password_fd */ -1,
                       base::Bind([](authpolicy::ErrorType error) {
                         EXPECT_EQ(authpolicy::ERROR_BAD_MACHINE_NAME, error);
                       }));
   client.JoinAdDomain(">nvalidname", kCorrectUserName, /* password_fd */ -1,
                       base::Bind([](authpolicy::ErrorType error) {
                         EXPECT_EQ(authpolicy::ERROR_BAD_MACHINE_NAME, error);
                       }));
+
+  base::RunLoop().RunUntilIdle();
 }
 
 // Tests parsing user name.
-TEST(FakeAuthPolicyClientTest, JoinAdDomain_ParseUPN) {
-  FakeAuthPolicyClient client;
+TEST_F(FakeAuthPolicyClientTest, JoinAdDomain_ParseUPN) {
   client.set_started(true);
   client.JoinAdDomain(kCorrectMachineName, "user@realm.com",
                       /* password_fd */ -1,
                       base::Bind([](authpolicy::ErrorType error) {
                         EXPECT_EQ(authpolicy::ERROR_NONE, error);
                       }));
   client.JoinAdDomain(kCorrectMachineName, "user", /* password_fd */ -1,
                       base::Bind([](authpolicy::ErrorType error) {
                         EXPECT_EQ(authpolicy::ERROR_PARSE_UPN_FAILED, error);
                       }));
   client.JoinAdDomain(kCorrectMachineName, "", /* password_fd */ -1,
                       base::Bind([](authpolicy::ErrorType error) {
                         EXPECT_EQ(authpolicy::ERROR_PARSE_UPN_FAILED, error);
                       }));
   client.JoinAdDomain(kCorrectMachineName, "user@", /* password_fd */ -1,
                       base::Bind([](authpolicy::ErrorType error) {
                         EXPECT_EQ(authpolicy::ERROR_PARSE_UPN_FAILED, error);
                       }));
   client.JoinAdDomain(kCorrectMachineName, "@realm", /* password_fd */ -1,
                       base::Bind([](authpolicy::ErrorType error) {
                         EXPECT_EQ(authpolicy::ERROR_PARSE_UPN_FAILED, error);
                       }));
   client.JoinAdDomain(kCorrectMachineName, "user@realm@com",
                       /* password_fd */ -1,
                       base::Bind([](authpolicy::ErrorType error) {
                         EXPECT_EQ(authpolicy::ERROR_PARSE_UPN_FAILED, error);
                       }));
+
+  base::RunLoop().RunUntilIdle();
 }
 
 // Tests calls to not started authpolicyd fails.
-TEST(FakeAuthPolicyClientTest, NotStartedAuthPolicyService) {
-  FakeAuthPolicyClient client;
+TEST_F(FakeAuthPolicyClientTest, NotStartedAuthPolicyService) {
   client.JoinAdDomain(kCorrectMachineName, kCorrectUserName,
                       /* password_fd */ -1,
                       base::Bind([](authpolicy::ErrorType error) {
                         EXPECT_EQ(authpolicy::ERROR_DBUS_FAILURE, error);
                       }));
   client.AuthenticateUser(
       kCorrectUserName, /* password_fd */ -1,
       base::Bind([](authpolicy::ErrorType error,
                     const authpolicy::ActiveDirectoryAccountData&) {
         EXPECT_EQ(authpolicy::ERROR_DBUS_FAILURE, error);
       }));
   client.RefreshDevicePolicy(
       base::Bind([](bool success) { EXPECT_FALSE(success); }));
   client.RefreshUserPolicy(
       AccountId::FromUserEmail(kCorrectUserName),
       base::Bind([](bool success) { EXPECT_FALSE(success); }));
+
+  base::RunLoop().RunUntilIdle();
 }
 
 }  // namespace chromeos