Add AuthPolicyLoginHelper

chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/macros.h"
 #include "chrome/browser/chromeos/login/enrollment/enrollment_screen.h"
 #include "chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper.h"
 #include "chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.h"
 #include "chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_mock.h"
 #include "chrome/browser/chromeos/login/login_manager_test.h"
 #include "chrome/browser/chromeos/login/startup_utils.h"
 #include "chrome/browser/chromeos/login/test/js_checker.h"
 #include "chrome/browser/chromeos/login/test/oobe_screen_waiter.h"
 #include "chrome/browser/chromeos/login/ui/login_display_host.h"
 #include "chrome/browser/chromeos/login/wizard_controller.h"
 #include "chrome/browser/chromeos/policy/enrollment_status_chromeos.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/dbus/upstart_client.h"
+#include "content/public/test/browser_test_utils.h"
 #include "content/public/test/test_utils.h"
 
 using testing::_;
 using testing::Invoke;
 using testing::InvokeWithoutArgs;
 
 namespace chromeos {
 
 namespace {
 
@@ skipping 119 matching lines @@
         EnterpriseEnrollmentHelperMock* enrollment_helper) {
       // Causes the attribute-prompt flow to activate.
       EXPECT_CALL(*enrollment_helper, EnrollUsingAuthCode("test_auth_code", _))
           .WillOnce(InvokeWithoutArgs([this]() {
             this->enrollment_screen()->JoinDomain(base::BindOnce([](
                 const std::string& realm) { EXPECT_EQ(kAdTestRealm, realm); }));
           }));
     });
   }
 
+  void SetupActiveDirectoryJSNotifications() {
+    js_checker().Evaluate(
+        "var testShowStep = login.OAuthEnrollmentScreen.showStep;"
+        "login.OAuthEnrollmentScreen.showStep = function(step) {"
+        "  testShowStep(step);"
+        "  if (step == 'working') {"
+        "    window.domAutomationController.setAutomationId(0);"
+        "    window.domAutomationController.send('ShowSpinnerScreen');"
+        "  }"
+        "}");
+    js_checker().Evaluate(
+        "var testInvalidateAd = login.OAuthEnrollmentScreen.invalidateAd;"
+        "login.OAuthEnrollmentScreen.invalidateAd = function(machineName, "
+        "user, errorState) {"
+        "  testInvalidateAd(machineName, user, errorState);"
+        "  window.domAutomationController.setAutomationId(0);"
+        "  window.domAutomationController.send('ShowJoinDomainError');"
+        "}");
+  }
+
+  void WaitForMessage(const std::string& expected_message) {
+    content::DOMMessageQueue message_queue;

[xiyuan, 2017/04/07 15:04:24]

This impl pattern would cause test flakes. This has bite us before. We need to
make sure DOMMessageQueue is created before the DOM message is generated since
any messages sent before the construction is lost.

In our case here, we need to create DOMMessageQueue before
SubmitActiveDirectoryCredentials. JS eval is an IPC and has a nested loop and
its own DOMMessageQueue to wait to JS exec finish. There is no guarantee that
WaitForMessage would be called before JS sends back the message.

Consider move DOMMessageQueue out of here and put it before
SubmitActiveDirectoryCredentials and pass a pointer or reference to this
function.

[Roman Sorokin (ftl), 2017/04/10 16:09:00]

Done.

+    std::string message;
+    do {
+      ASSERT_TRUE(message_queue.WaitForMessage(&message));
+    } while (message != expected_message);
+  }
+
   // Fills out the UI with device attribute information and submits it.
   void SubmitAttributePromptUpdate() {
     // Fill out the attribute prompt info and submit it.
     js_checker().ExecuteAsync("$('oauth-enroll-asset-id').value = 'asset_id'");
     js_checker().ExecuteAsync("$('oauth-enroll-location').value = 'location'");
     js_checker().Evaluate(
         "$('oauth-enroll-attribute-prompt-card').fire('submit')");
   }
 
   // Completes the enrollment process.
@@ skipping 122 matching lines @@
                        TestActiveDirectoryEnrollment_Success) {
   ShowEnrollmentScreen();
   DisableAttributePromptUpdate();
   SetupActiveDirectoryJoin();
   SubmitEnrollmentCredentials();
 
   chromeos::DBusThreadManager::Get()
       ->GetUpstartClient()
       ->StartAuthPolicyService();
 
+  SetupActiveDirectoryJSNotifications();
   SubmitActiveDirectoryCredentials("machine_name", kAdTestUser, "password");
+  WaitForMessage("\"ShowSpinnerScreen\"");
   EXPECT_FALSE(IsStepDisplayed("ad-join"));
 
   CompleteEnrollment();
   // Verify that the success page is displayed.
   EXPECT_TRUE(IsStepDisplayed("success"));
   EXPECT_FALSE(IsStepDisplayed("error"));
 
   // We have to remove the enrollment_helper before the dtor gets called.
   enrollment_screen()->enrollment_helper_.reset();
 }
 
 // Shows the enrollment screen and mocks the enrollment helper to show Active
 // Directory domain join screen. Verifies the domain join screen is displayed.
 // Submits Active Directory different incorrect credentials. Verifies that the
 // correct error is displayed.
 IN_PROC_BROWSER_TEST_F(EnterpriseEnrollmentTest,
                        TestActiveDirectoryEnrollment_UIErrors) {
   ShowEnrollmentScreen();
   SetupActiveDirectoryJoin();
   SubmitEnrollmentCredentials();
 
   chromeos::DBusThreadManager::Get()
       ->GetUpstartClient()
       ->StartAuthPolicyService();
 
   // Checking error in case of empty password. Whether password is not empty
   // being checked in the UI. Machine name length is checked after that in the
   // authpolicyd.
+  SetupActiveDirectoryJSNotifications();
   SubmitActiveDirectoryCredentials("too_long_machine_name", kAdTestUser, "");
   EXPECT_TRUE(IsStepDisplayed("ad-join"));
   js_checker().ExpectFalse(std::string(kAdMachineNameInput) + ".isInvalid");
   js_checker().ExpectFalse(std::string(kAdUsernameInput) + ".isInvalid");
   js_checker().ExpectTrue(std::string(kAdPasswordInput) + ".isInvalid");
 
   // Checking error in case of too long machine name.
   SubmitActiveDirectoryCredentials("too_long_machine_name", kAdTestUser,
                                    "password");
+  WaitForMessage("\"ShowJoinDomainError\"");
   EXPECT_TRUE(IsStepDisplayed("ad-join"));
   js_checker().ExpectTrue(std::string(kAdMachineNameInput) + ".isInvalid");
   js_checker().ExpectFalse(std::string(kAdUsernameInput) + ".isInvalid");
   js_checker().ExpectFalse(std::string(kAdPasswordInput) + ".isInvalid");
 
   // Checking error in case of bad username (without realm).
   SubmitActiveDirectoryCredentials("machine_name", "test_user", "password");
+  WaitForMessage("\"ShowJoinDomainError\"");
   EXPECT_TRUE(IsStepDisplayed("ad-join"));
   js_checker().ExpectFalse(std::string(kAdMachineNameInput) + ".isInvalid");
   js_checker().ExpectTrue(std::string(kAdUsernameInput) + ".isInvalid");
   js_checker().ExpectFalse(std::string(kAdPasswordInput) + ".isInvalid");
 
   // We have to remove the enrollment_helper before the dtor gets called.
   enrollment_screen()->enrollment_helper_.reset();
 }
 
 }  // namespace chromeos