third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp - Issue 2794453002: [Bindings] Replace V8HiddenValue in generated code with V8PrivateProperty

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp

Issue 2794453002: [Bindings] Replace V8HiddenValue in generated code with V8PrivateProperty (Closed)

Patch Set: . Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl ('K') | « third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBufferView.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp

index c2d36cefaa23f1a24435623e925fd772276bf238..092bc9fe2d5712b1dbd90ffeb3d90f890f592fd7 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp

@@ -64,6 +64,9 @@ static void typeAttributeGetter(const v8::FunctionCallbackInfo<v8::Value>& info)

}

static void typeAttributeSetter(v8::Local<v8::Value> v8Value, const v8::FunctionCallbackInfo<v8::Value>& info) {

+ v8::Isolate* isolate = info.GetIsolate();

+ ALLOW_UNUSED_LOCAL(isolate);

v8::Local<v8::Object> holder = info.Holder();

SVGTestInterface* impl = V8SVGTestInterface::toImpl(holder);