third_party/WebKit/Source/bindings/scripts/v8_attributes.py - Issue 2794453002: [Bindings] Replace V8HiddenValue in generated code with V8PrivateProperty

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_attributes.py

Issue 2794453002: [Bindings] Replace V8HiddenValue in generated code with V8PrivateProperty (Closed)

Patch Set: . Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/scripts/v8_attributes.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_attributes.py b/third_party/WebKit/Source/bindings/scripts/v8_attributes.py

index 9f56eb2fbd9dfc2ca0f62b837f13ef72a0805df6..da3f3371db5b8830659deec390adb32853040910 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_attributes.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_attributes.py

@@ -111,7 +111,7 @@ def attribute_context(interface, attribute, interfaces):

cached_attribute_validation_method = extended_attributes.get('CachedAttribute')

keep_alive_for_gc = is_keep_alive_for_gc(interface, attribute)

if cached_attribute_validation_method or keep_alive_for_gc:

- includes.add('bindings/core/v8/V8HiddenValue.h')

+ includes.add('bindings/core/v8/V8PrivateProperty.h')

# [CachedAccessor]

is_cached_accessor = 'CachedAccessor' in extended_attributes