third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h - Issue 2794453002: [Bindings] Replace V8HiddenValue in generated code with V8PrivateProperty

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h

Issue 2794453002: [Bindings] Replace V8HiddenValue in generated code with V8PrivateProperty (Closed)

Patch Set: . Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h b/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h

index e6a1fdff4e79929855e6928f685656811909c5c3..265b7d02fd626606f0ed8259abcb56a42465722a 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h

@@ -177,6 +177,7 @@ class CORE_EXPORT V8PrivateProperty {

static v8::Local<v8::Private> createV8Private(v8::Isolate*,

const char* symbol);

+ // TODO(peria): Remove this method. We should not use v8::Private::ForApi().

static v8::Local<v8::Private> createCachedV8Private(v8::Isolate*,

const char* symbol);