[Bindings] Replace V8HiddenValue in generated code with V8PrivateProperty

third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl

 {% from 'utilities.cpp.tmpl' import declare_enum_validation_variable, v8_value_to_local_cpp_value %}
 
 {##############################################################################}
 {% macro generate_method(method, world_suffix) %}
 static void {{method.name}}{{method.overload_index}}Method{{world_suffix}}(const v8::FunctionCallbackInfo<v8::Value>& info) {
   {% filter format_remove_duplicates([
       'ExceptionState exceptionState',
       'ScriptState* scriptState = ']) %}
   {% set define_exception_state -%}
   ExceptionState exceptionState(info.GetIsolate(), ExceptionState::ExecutionContext, "{{interface_name}}", "{{method.name}}");
@@ skipping 516 matching lines @@
 
   v8::Local<v8::FunctionTemplate> methodTemplate = data->findOrCreateOperationTemplate(world, &domTemplateKey, {{v8_class_or_partial}}::{{method.name}}MethodCallback{{world_suffix}}, v8Undefined(), signature, {{method.length}});
   // Return the function by default, unless the user script has overwritten it.
   v8SetReturnValue(info, methodTemplate->GetFunction(info.GetIsolate()->GetCurrentContext()).ToLocalChecked());
 
   {{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder());
   if (!BindingSecurity::shouldAllowAccessTo(currentDOMWindow(info.GetIsolate()), impl, BindingSecurity::ErrorReportOption::DoNotReport)) {
     return;
   }
 
-  v8::Local<v8::Value> hiddenValue = V8HiddenValue::getHiddenValue(ScriptState::current(info.GetIsolate()), v8::Local<v8::Object>::Cast(info.Holder()), v8AtomicString(info.GetIsolate(), "{{method.name}}"));
-  if (!hiddenValue.IsEmpty()) {
-    v8SetReturnValue(info, hiddenValue);
+  v8::Local<v8::Value> propertyValue =
+      V8PrivateProperty::createSymbol(info.GetIsolate(), "{{method.name}}")

[Yuki, 2017/03/31 13:38:29]

Could you add a comment that {{method.name}} was chosen so that it matches with
|name| in FooOriginSafeMethodSetter in interface.cpp.tmpl.

[peria, 2017/04/03 04:58:44]

Done.

+      .getOrUndefined(v8::Local<v8::Object>::Cast(info.Holder()));

[Yuki, 2017/03/31 13:38:30]

nit: 4 space indent in addition to the level of V8PrivateProperty::...

[peria, 2017/04/03 04:58:43]

Done.

+  if (!propertyValue->IsUndefined()) {

[Yuki, 2017/03/31 13:38:29]

The value can be |undefined|.

[peria, 2017/04/03 04:58:44]

Done.

+    v8SetReturnValue(info, propertyValue);
   }
 }
 {% endmacro %}
 
 {% macro origin_safe_method_getter_callback(method, world_suffix) %}
 void {{v8_class_or_partial}}::{{method.name}}OriginSafeMethodGetterCallback{{world_suffix}}(v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>& info) {
   {{cpp_class}}V8Internal::{{method.name}}OriginSafeMethodGetter{{world_suffix}}(info);
 }
 {% endmacro %}
 
@@ skipping 94 matching lines @@
   {{method_configuration(method) | indent(2)}}
 };
 for (const auto& methodConfig : {{method.name}}MethodConfiguration)
   V8DOMConfiguration::installMethod(isolate, world, v8::Local<v8::Object>(), prototypeObject, interfaceObject, signature, methodConfig);
 {% endfilter %}{# runtime_enabled() #}
 {% endfilter %}{# exposed() #}
 {% endfilter %}{# secure_context() #}
 {% endfor %}
 {% endif %}
 {%- endmacro %}