[Bindings] Replace V8HiddenValue in generated code with V8PrivateProperty

third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8PrivateProperty_h
 #define V8PrivateProperty_h
 
 #include <memory>
 
 #include "bindings/core/v8/ScriptPromiseProperties.h"
@@ skipping 150 matching lines @@
       privateProp->m_symbolWindowDocumentCachedAccessor.set(
           isolate, createCachedV8Private(
                        isolate, V8_PRIVATE_PROPERTY_SYMBOL_STRING(
                                     "Window", "DocumentCachedAccessor")));
     }
     return Symbol(
         isolate,
         privateProp->m_symbolWindowDocumentCachedAccessor.newLocal(isolate));
   }
 
   static Symbol createSymbol(v8::Isolate* isolate, const char* symbol) {

[Yuki, 2017/03/31 13:38:29]

This method should be renamed to getOrCreateSymbol or simply getSymbol, as we're
now using createCachedV8Private.

[peria, 2017/04/03 04:58:43]

Done.

     return Symbol(isolate, createCachedV8Private(isolate, symbol));
   }
 
  private:
   V8PrivateProperty() {}
 
   static v8::Local<v8::Private> createV8Private(v8::Isolate*,
                                                 const char* symbol);
+  // TODO(peria): Remove this method. We should not use v8::Private::ForApi().
   static v8::Local<v8::Private> createCachedV8Private(v8::Isolate*,
                                                       const char* symbol);
 
 #define V8_PRIVATE_PROPERTY_DECLARE_MEMBER(InterfaceName, KeyName) \
   v8::Eternal<v8::Private> V8_PRIVATE_PROPERTY_MEMBER_NAME(        \
       InterfaceName, KeyName);  // NOLINT(readability/naming/underscores)
   V8_PRIVATE_PROPERTY_FOR_EACH(V8_PRIVATE_PROPERTY_DECLARE_MEMBER)
 #undef V8_PRIVATE_PROPERTY_DECLARE_MEMBER
 
   // TODO(peria): Do not use this specialized hack for
   // Window#DocumentCachedAccessor. This is required to put v8::Private key in
   // a snapshot, and it cannot be a v8::Eternal<> due to V8 serializer's
   // requirement.
   ScopedPersistent<v8::Private> m_symbolWindowDocumentCachedAccessor;
 };
 
 }  // namespace blink
 
 #endif  // V8PrivateProperty_h