Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc

Issue 2794413002: [USS] Add SyncMetadataStore interface (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc
diff --git a/components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc b/components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc
index 9ed914081904a0e634b7034eaaa590e134141bcb..998a14c5986124a01cb1c65e5ad71418b23faeae 100644
--- a/components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc
+++ b/components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc
@@ -15,13 +15,13 @@
#include "base/memory/ptr_util.h"
#include "base/strings/utf_string_conversions.h"
#include "components/autofill/core/browser/proto/autofill_sync.pb.h"
-#include "components/autofill/core/browser/webdata/autofill_metadata_change_list.h"
#include "components/autofill/core/browser/webdata/autofill_table.h"
#include "components/autofill/core/browser/webdata/autofill_webdata_backend.h"
#include "components/autofill/core/browser/webdata/autofill_webdata_service.h"
#include "components/sync/model/entity_data.h"
#include "components/sync/model/model_type_change_processor.h"
#include "components/sync/model/mutable_data_batch.h"
+#include "components/sync/model_impl/on_disk_metadata_change_list.h"
#include "net/base/escape.h"
using base::Optional;
@@ -216,7 +216,8 @@ class SyncDifferenceTracker {
metadata_change_list.get());
}
}
- return static_cast<AutofillMetadataChangeList*>(metadata_change_list.get())
+ return static_cast<syncer::OnDiskMetadataChangeList*>(
+ metadata_change_list.get())
->TakeError();
pavely 2017/04/06 22:56:42 If you decide to keep TakeError in MetadataChangeL
Gang Wu 2017/04/21 05:28:03 Done.
}
@@ -319,8 +320,8 @@ AutocompleteSyncBridge::~AutocompleteSyncBridge() {
std::unique_ptr<MetadataChangeList>
AutocompleteSyncBridge::CreateMetadataChangeList() {
DCHECK(thread_checker_.CalledOnValidThread());
- return base::MakeUnique<AutofillMetadataChangeList>(GetAutofillTable(),
- syncer::AUTOFILL);
+ return base::MakeUnique<syncer::OnDiskMetadataChangeList>(GetAutofillTable(),
+ syncer::AUTOFILL);
}
Optional<syncer::ModelError> AutocompleteSyncBridge::MergeSyncData(
@@ -412,8 +413,9 @@ void AutocompleteSyncBridge::ActOnLocalChanges(
return;
}
- auto metadata_change_list = base::MakeUnique<AutofillMetadataChangeList>(
- GetAutofillTable(), syncer::AUTOFILL);
+ auto metadata_change_list =
+ base::MakeUnique<syncer::OnDiskMetadataChangeList>(GetAutofillTable(),
+ syncer::AUTOFILL);
for (const auto& change : changes) {
const std::string storage_key = GetStorageKeyFromModel(change.key());
switch (change.type()) {

Powered by Google App Engine
This is Rietveld 408576698