Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3228)

Unified Diff: cc/output/overlay_unittest.cc

Issue 2794343003: cc: Allow overlay candidates with transforms. (Closed)
Patch Set: OverlayCheck_PArams default transform to none. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/overlay_strategy_single_on_top.cc ('k') | ui/ozone/common/gpu/ozone_gpu_message_params.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/overlay_unittest.cc
diff --git a/cc/output/overlay_unittest.cc b/cc/output/overlay_unittest.cc
index 70d81f6fc6b5b91cad316212a151b30d23c6c814..bd6f3f159681536b9b466059a2bfa02b3de94290 100644
--- a/cc/output/overlay_unittest.cc
+++ b/cc/output/overlay_unittest.cc
@@ -1006,14 +1006,14 @@ TEST_F(SingleOverlayOnTopTest, AllowPositiveScaleTransform) {
EXPECT_EQ(1U, candidate_list.size());
}
-TEST_F(SingleOverlayOnTopTest, RejectTransform) {
+TEST_F(SingleOverlayOnTopTest, AcceptMirrorYTransform) {
gfx::Rect rect = kOverlayRect;
rect.Offset(0, -rect.height());
std::unique_ptr<RenderPass> pass = CreateRenderPass();
CreateCandidateQuadAt(resource_provider_.get(),
pass->shared_quad_state_list.back(), pass.get(), rect);
- pass->shared_quad_state_list.back()
- ->quad_to_target_transform.RotateAboutZAxis(90.f);
+ pass->shared_quad_state_list.back()->quad_to_target_transform.Scale(1.f,
+ -1.f);
OverlayCandidateList candidate_list;
base::flat_map<int, FilterOperations*> render_pass_filters;
@@ -1022,7 +1022,7 @@ TEST_F(SingleOverlayOnTopTest, RejectTransform) {
resource_provider_.get(), pass.get(), render_pass_filters,
render_pass_background_filters, &candidate_list, nullptr, nullptr,
&damage_rect_, &content_bounds_);
- ASSERT_EQ(0U, candidate_list.size());
+ ASSERT_EQ(1U, candidate_list.size());
}
TEST_F(UnderlayTest, Allow90DegreeRotation) {
« no previous file with comments | « cc/output/overlay_strategy_single_on_top.cc ('k') | ui/ozone/common/gpu/ozone_gpu_message_params.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698