| Index: components/ntp_tiles/icon_cacher_impl_unittest.cc
|
| diff --git a/components/ntp_tiles/icon_cacher_impl_unittest.cc b/components/ntp_tiles/icon_cacher_impl_unittest.cc
|
| index 4a2ddc2513d15138b61251ba2eb978d72ae774fe..f1398e056eca55c1d4e1ba9d31b23d2f2c0969f7 100644
|
| --- a/components/ntp_tiles/icon_cacher_impl_unittest.cc
|
| +++ b/components/ntp_tiles/icon_cacher_impl_unittest.cc
|
| @@ -23,6 +23,7 @@
|
| #include "components/image_fetcher/core/image_decoder.h"
|
| #include "components/image_fetcher/core/image_fetcher.h"
|
| #include "components/image_fetcher/core/request_metadata.h"
|
| +#include "net/traffic_annotation/network_traffic_annotation_test_helper.h"
|
| #include "testing/gmock/include/gmock/gmock.h"
|
| #include "testing/gtest/include/gtest/gtest.h"
|
| #include "ui/base/resource/resource_bundle.h"
|
| @@ -48,10 +49,11 @@ class MockImageFetcher : public image_fetcher::ImageFetcher {
|
| void(image_fetcher::ImageFetcher::DataUseServiceName name));
|
| MOCK_METHOD1(SetImageDownloadLimit,
|
| void(base::Optional<int64_t> max_download_bytes));
|
| - MOCK_METHOD3(StartOrQueueNetworkRequest,
|
| + MOCK_METHOD4(StartOrQueueNetworkRequest,
|
| void(const std::string& id,
|
| const GURL& image_url,
|
| - const ImageFetcherCallback& callback));
|
| + const ImageFetcherCallback& callback,
|
| + const net::NetworkTrafficAnnotationTag&));
|
| MOCK_METHOD1(SetDesiredImageFrameSize, void(const gfx::Size&));
|
| MOCK_METHOD0(GetImageDecoder, image_fetcher::ImageDecoder*());
|
| };
|
| @@ -240,7 +242,7 @@ TEST_F(IconCacherTest, LargeNotCachedAndFetchSucceeded) {
|
| data_use_measurement::DataUseUserData::NTP_TILES));
|
| EXPECT_CALL(*image_fetcher_, SetDesiredImageFrameSize(gfx::Size(128, 128)));
|
| EXPECT_CALL(*image_fetcher_,
|
| - StartOrQueueNetworkRequest(_, site_.large_icon_url, _))
|
| + StartOrQueueNetworkRequest(_, site_.large_icon_url, _, _))
|
| .WillOnce(PassFetch(128, 128));
|
| EXPECT_CALL(done, Run()).WillOnce(Quit(&loop));
|
| }
|
| @@ -264,7 +266,7 @@ TEST_F(IconCacherTest, SmallNotCachedAndFetchSucceeded) {
|
| data_use_measurement::DataUseUserData::NTP_TILES));
|
| EXPECT_CALL(*image_fetcher_, SetDesiredImageFrameSize(gfx::Size(128, 128)));
|
| EXPECT_CALL(*image_fetcher_,
|
| - StartOrQueueNetworkRequest(_, site_.favicon_url, _))
|
| + StartOrQueueNetworkRequest(_, site_.favicon_url, _, _))
|
| .WillOnce(PassFetch(128, 128));
|
| EXPECT_CALL(done, Run()).WillOnce(Quit(&loop));
|
| }
|
| @@ -286,7 +288,7 @@ TEST_F(IconCacherTest, LargeNotCachedAndFetchFailed) {
|
| data_use_measurement::DataUseUserData::NTP_TILES));
|
| EXPECT_CALL(*image_fetcher_, SetDesiredImageFrameSize(gfx::Size(128, 128)));
|
| EXPECT_CALL(*image_fetcher_,
|
| - StartOrQueueNetworkRequest(_, site_.large_icon_url, _))
|
| + StartOrQueueNetworkRequest(_, site_.large_icon_url, _, _))
|
| .WillOnce(FailFetch());
|
| }
|
|
|
| @@ -300,7 +302,7 @@ TEST_F(IconCacherTest, LargeNotCachedAndFetchFailed) {
|
| TEST_F(IconCacherTest, HandlesEmptyCallbacksNicely) {
|
| EXPECT_CALL(*image_fetcher_, SetDataUseServiceName(_));
|
| EXPECT_CALL(*image_fetcher_, SetDesiredImageFrameSize(_));
|
| - ON_CALL(*image_fetcher_, StartOrQueueNetworkRequest(_, _, _))
|
| + ON_CALL(*image_fetcher_, StartOrQueueNetworkRequest(_, _, _, _))
|
| .WillByDefault(PassFetch(128, 128));
|
| IconCacherImpl cacher(&favicon_service_, std::move(image_fetcher_));
|
| cacher.StartFetch(site_, base::Closure(), base::Closure());
|
| @@ -328,7 +330,7 @@ TEST_F(IconCacherTest, ProvidesDefaultIconAndSucceedsWithFetching) {
|
| data_use_measurement::DataUseUserData::NTP_TILES));
|
| EXPECT_CALL(*image_fetcher_, SetDesiredImageFrameSize(gfx::Size(128, 128)));
|
| EXPECT_CALL(*image_fetcher_,
|
| - StartOrQueueNetworkRequest(_, site_.large_icon_url, _))
|
| + StartOrQueueNetworkRequest(_, site_.large_icon_url, _, _))
|
| .WillOnce(PassFetch(128, 128));
|
|
|
| // Both callback are called async after the request but preliminary has to
|
|
|