Network traffic annotation added to image_data_fetcher.

components/favicon/core/large_icon_service.cc

Index: components/favicon/core/large_icon_service.cc
diff --git a/components/favicon/core/large_icon_service.cc b/components/favicon/core/large_icon_service.cc
index bf94e5b38ea09f0ccbe059df76ed3984f6c62e80..87f25d77b56086780d0e217bd430b5e1d570973b 100644
--- a/components/favicon/core/large_icon_service.cc
+++ b/components/favicon/core/large_icon_service.cc
@@ -339,10 +339,32 @@ void LargeIconService::
 
   image_fetcher_->SetDataUseServiceName(
       data_use_measurement::DataUseUserData::LARGE_ICON_SERVICE);
+  net::NetworkTrafficAnnotationTag traffic_annotation =
+      net::DefineNetworkTrafficAnnotation("...", R"(

[pkotwicz, 2017/05/12 17:10:31]

favicon_component

[Ramin Halavati, 2017/05/13 08:51:28]

Done.

+        semantics {
+          sender: "..."

[pkotwicz, 2017/05/12 17:10:31]

Favicon component

[Ramin Halavati, 2017/05/13 08:51:28]

Done.

+          description: "..."

[pkotwicz, 2017/05/12 17:10:31]

Sends a request to a Google server to retrieve the favicon bitmap for a page URL

[Ramin Halavati, 2017/05/13 08:51:28]

Done.

+          trigger: "..."

[pkotwicz, 2017/05/12 17:10:31]

A request can be sent for signed-in users when Chrome does not have a favicon
for a particular page. For instance, this is used by the new tab page for the
"most visited" tiles.

[Ramin Halavati, 2017/05/13 08:51:28]

Done.

+          data: "..."

[pkotwicz, 2017/05/12 17:10:31]

Page URL and desired icon size

[Ramin Halavati, 2017/05/13 08:51:29]

Done.

+          destination: WEBSITE/GOOGLE_OWNED_SERVICE/OTHER/LOCAL

[pkotwicz, 2017/05/12 17:10:31]

GOOGLE_OWNED_SERVICE

[Ramin Halavati, 2017/05/13 08:51:28]

Done.

+        }
+        policy {
+          cookies_allowed: false/true
+          cookies_store: "..."
+          setting: "..."
+          chrome_policy {
+            [POLICY_NAME] {
+              policy_options {mode: MANDATORY/RECOMMENDED/UNSET}
+              [POLICY_NAME]: ... //(value to disable it)
+            }
+          }
+          policy_exception_justification: "..."

[pkotwicz, 2017/05/12 17:10:31]

For the policy block, I think it should say this:

policy {
  cookies_allowed: false
  setting: "This feature cannot be disabled by settings."
  policy_exception_justification: "Not implemented."
}

[Ramin Halavati, 2017/05/13 08:51:28]

Done.

+        })");
   image_fetcher_->StartOrQueueNetworkRequest(
       server_request_url.spec(), server_request_url,
       base::Bind(&OnFetchIconFromGoogleServerComplete, favicon_service_,
-                 page_url, callback));
+                 page_url, callback),
+      traffic_annotation);
 }
 
 base::CancelableTaskTracker::TaskId