BMP-in-ICO should respect alpha in Windows V3 32bpp RGB bitmaps.

BMP-in-ICO should respect alpha in Windows V3 32bpp RGB bitmaps.

Confirmed with Firefox source code and some vague Wikipedia references, as well
as IE's behavior on a test image.

BUG=38618
TEST=none
TBR=senorblanco

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173567

[Peter Kasting, 2014-05-07 22:18:30]

Followon to yesterday's patch.  Turns out there's another wrinkle in alpha
support: inside ICO files we're supposed to respect 32bpp alpha in cases where
we don't for standalone BMPs.

I hate BMP.

TBRing since this broke a test.

[Peter Kasting, 2014-05-07 22:20:43]

Committed patchset #1 manually as r173567 (presubmit successful).

[Stephen White, 2014-05-07 22:38:55]

LGTM, but please fix the typo in a followup.

https://codereview.chromium.org/279433002/diff/1/Source/platform/image-decode...
File Source/platform/image-decoders/bmp/BMPImageReader.h (right):

https://codereview.chromium.org/279433002/diff/1/Source/platform/image-decode...
Source/platform/image-decoders/bmp/BMPImageReader.h:71:
BMPImageReader(ImageDecoder* parent, size_t decodedAndHeaderOffset, size_t
imgDataOffset, bool m_isInICO);
Spurious m_.

[Peter Kasting, 2014-05-07 22:41:28]

https://codereview.chromium.org/279433002/diff/1/Source/platform/image-decode...
File Source/platform/image-decoders/bmp/BMPImageReader.h (right):

https://codereview.chromium.org/279433002/diff/1/Source/platform/image-decode...
Source/platform/image-decoders/bmp/BMPImageReader.h:71:
BMPImageReader(ImageDecoder* parent, size_t decodedAndHeaderOffset, size_t
imgDataOffset, bool m_isInICO);
On 2014/05/07 22:38:55, Stephen White wrote:
> Spurious m_.

Darn!  Good catch.  Will fix.