Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 2794303002: Deprecate resource requests whose URLs contain raw newlines. (Closed)
Patch Set: Rebase. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/Deprecation.cpp
diff --git a/third_party/WebKit/Source/core/frame/Deprecation.cpp b/third_party/WebKit/Source/core/frame/Deprecation.cpp
index 5de1b1284ffe90743f4d718e5e0eeb9ee1159c6f..90782d215b103e29d6b30272fbe7d6b0155a7bc4 100644
--- a/third_party/WebKit/Source/core/frame/Deprecation.cpp
+++ b/third_party/WebKit/Source/core/frame/Deprecation.cpp
@@ -424,6 +424,16 @@ String Deprecation::deprecationMessage(UseCounter::Feature feature) {
"the 'script-src' directive for Workers",
M60, "5922594955984896");
+ case UseCounter::CanRequestURLHTTPContainingNewline:
+ return String::format(
+ "Resource requests whose URLs contain raw newline characters are "
+ "deprecated, and may be blocked in %s. Please remove newlines from "
+ "places like element attribute values in order to continue loading "
+ "those resources. See "
+ "https://www.chromestatus.com/features/5735596811091968 for more "
+ "details.",
+ milestoneString(M60));
+
// Features that aren't deprecated don't have a deprecation message.
default:
return String();
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698