Issue 279423006: Include path to chromium's trunk should be before webrtc when building libjingle (otherwise e.g. we…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 279423006: Include path to chromium's trunk should be before webrtc when building libjingle (otherwise e.g. we… (Closed)

Created:
6 years, 7 months ago by hellner1

Modified:
6 years, 7 months ago

Reviewers:
Mallinath (Gone from Chromium)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Include path to chromium's trunk should be before webrtc when building libjingle (otherwise e.g. webrtc's base could be picked up when trunk/base is intended). BUG=N/A

Patch Set 1 #

Patch Set 2 : reorder and removed unnecessary forward slash #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	third_party/libjingle/libjingle.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

hellner1

solves http://chromegw.corp.google.com/i/internal.chromium.webrtc.fyi/builders/Linux/builds/5614/steps/compile/logs/stdio tested locally

6 years, 7 months ago (2014-05-13 16:36:46 UTC) #1

Mallinath (Gone from Chromium)

6 years, 7 months ago (2014-05-13 16:37:58 UTC) #2

On 2014/05/13 16:36:46, hellner1 wrote:
> solves
>
http://chromegw.corp.google.com/i/internal.chromium.webrtc.fyi/builders/Linux...
> tested locally

lgtm

Expand Messages | Collapse Messages