Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1011)

Issue 279423004: Remove DebuggerAgent. (Closed)

Created:
6 years, 7 months ago by Yang
Modified:
6 years, 7 months ago
Reviewers:
Sven Panne, yurys
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : remove some more includes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -1445 lines) Patch
M include/v8-debug.h View 3 chunks +0 lines, -34 lines 0 comments Download
M samples/lineprocessor.cc View 4 chunks +0 lines, -41 lines 0 comments Download
M src/api.cc View 2 chunks +1 line, -23 lines 0 comments Download
M src/d8.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/d8.cc View 4 chunks +1 line, -30 lines 0 comments Download
M src/d8-debug.h View 1 1 chunk +0 lines, -113 lines 0 comments Download
M src/d8-debug.cc View 1 2 chunks +0 lines, -215 lines 0 comments Download
M src/d8-readline.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug.h View 6 chunks +5 lines, -50 lines 0 comments Download
M src/debug.cc View 7 chunks +3 lines, -118 lines 0 comments Download
D src/debug-agent.h View 1 chunk +0 lines, -93 lines 0 comments Download
D src/debug-agent.cc View 1 chunk +0 lines, -481 lines 0 comments Download
M src/execution.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/isolate.h View 2 chunks +0 lines, -2 lines 0 comments Download
M test/cctest/test-debug.cc View 3 chunks +78 lines, -237 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yang
6 years, 7 months ago (2014-05-13 13:40:34 UTC) #1
Sven Panne
LGTM, but let's wait a little bit before committing to see if there are any ...
6 years, 7 months ago (2014-05-14 08:38:23 UTC) #2
Yang
Committed patchset #2 manually as r21315 (presubmit successful).
6 years, 7 months ago (2014-05-14 16:28:59 UTC) #3
yurys
Now that v8's debug agent is removed what is the current way for debugging Node.js? ...
6 years, 7 months ago (2014-05-23 12:30:07 UTC) #4
Yang
On 2014/05/23 12:30:07, yurys wrote: > Now that v8's debug agent is removed what is ...
6 years, 7 months ago (2014-05-23 12:32:48 UTC) #5
yurys
6 years, 7 months ago (2014-05-23 12:35:04 UTC) #6
Message was sent while issue was closed.
On 2014/05/23 12:32:48, Yang wrote:
> On 2014/05/23 12:30:07, yurys wrote:
> > Now that v8's debug agent is removed what is the current way for debugging
> > Node.js?
> > 
> > I'm also curious if it's a part of a bigger debugger clean-up and if so are
> you
> > going to remove other methods related to v8 built-in debugging protocol?
> 
> I wrote a post to v8-users upfront. I expect Node.js to implement the agent by
> themselves. I don't think that including the socket connection should be part
of
> v8.
> 
> I'll leave the implementation of the debugging protocol though, since
> Debug::SendCommand should still work.

Got it. Thanks for clarifying!

Powered by Google App Engine
This is Rietveld 408576698