Add initial support for native Linux desktop notifications

chrome/browser/notifications/notification_display_service_factory.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/notification_display_service_factory.h"
 
 #include "base/command_line.h"
 #include "base/memory/singleton.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/notifications/message_center_display_service.h"
 #include "chrome/browser/notifications/notification_ui_manager.h"
 #include "chrome/browser/profiles/incognito_helpers.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/chrome_features.h"
 #include "components/keyed_service/content/browser_context_dependency_manager.h"
 
-#if defined(OS_ANDROID) || defined(OS_MACOSX)
+#if defined(OS_ANDROID) || defined(OS_MACOSX) || \
+    (defined(OS_LINUX) && !defined(OS_CHROMEOS))

[Lei Zhang, 2017/04/04 07:47:21]

To make this even longer, do we need to gate this on defined(USE_GIO) as well,
in case someone building Chromium decides to set use_gio = false?

[Peter Beverloo, 2017/04/04 13:34:46]

It probably makes sense to use a BUILDFLAG for this so that we can define the
logic once in GN.

[Tom (Use chromium acct), 2017/04/04 21:47:10]

Added the BUILDFLAG and made the condition depend on use_gio as well.

 #include "chrome/browser/notifications/native_notification_display_service.h"
 #endif
 
 // static
 NotificationDisplayService* NotificationDisplayServiceFactory::GetForProfile(
     Profile* profile) {
   return static_cast<NotificationDisplayService*>(
       GetInstance()->GetServiceForBrowserContext(profile, true /* create */));
 }
 
@@ skipping 13 matching lines @@
 //   - Mac uses the MessageCenterDisplayService by default, but can use the
 //     NativeNotificationDisplayService by using the chrome://flags or via
 //     the --enable-features=NativeNotifications command line flag.
 //   - All other platforms always use the MessageCenterDisplayService.
 KeyedService* NotificationDisplayServiceFactory::BuildServiceInstanceFor(
     content::BrowserContext* context) const {
 #if defined(OS_ANDROID)
   return new NativeNotificationDisplayService(
       Profile::FromBrowserContext(context),
       g_browser_process->notification_platform_bridge());
-#elif defined(OS_MACOSX)
-  if (base::FeatureList::IsEnabled(features::kNativeNotifications)) {
+#elif defined(OS_MACOSX) || (defined(OS_LINUX) && !defined(OS_CHROMEOS))
+  if (base::FeatureList::IsEnabled(features::kNativeNotifications) &&
+      g_browser_process->notification_platform_bridge()) {
     return new NativeNotificationDisplayService(
         Profile::FromBrowserContext(context),
         g_browser_process->notification_platform_bridge());
   }
 #endif
   return new MessageCenterDisplayService(
       Profile::FromBrowserContext(context),
       g_browser_process->notification_ui_manager());
 }
 
 content::BrowserContext*
 NotificationDisplayServiceFactory::GetBrowserContextToUse(
     content::BrowserContext* context) const {
   return chrome::GetBrowserContextOwnInstanceInIncognito(context);
 }