Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2279)

Unified Diff: net/spdy/spdy_frame_builder.cc

Issue 2794063002: Add a SpdyFramer extension API implementation. (Closed)
Patch Set: Add BeginNewExtensionFrame. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_frame_builder.cc
diff --git a/net/spdy/spdy_frame_builder.cc b/net/spdy/spdy_frame_builder.cc
index 172f9d2ab6ce7825a0ec3d212f35ec4f0e9a5cc6..fe6ae6034dc6587da818af0285a138934e8c1810 100644
--- a/net/spdy/spdy_frame_builder.cc
+++ b/net/spdy/spdy_frame_builder.cc
@@ -131,6 +131,25 @@ bool SpdyFrameBuilder::BeginNewFrame(const SpdyFramer& framer,
size_t length) {
uint8_t raw_frame_type = SerializeFrameType(type);
DCHECK(IsDefinedFrameType(raw_frame_type));
+ return BeginNewFrameInternal(framer, raw_frame_type, flags, stream_id,
+ length);
+}
+
+bool SpdyFrameBuilder::BeginNewExtensionFrame(const SpdyFramer& framer,
+ uint8_t raw_frame_type,
+ uint8_t flags,
+ SpdyStreamId stream_id,
+ size_t length) {
+ DCHECK(!IsDefinedFrameType(raw_frame_type));
+ return BeginNewFrameInternal(framer, raw_frame_type, flags, stream_id,
+ length);
+}
+
+bool SpdyFrameBuilder::BeginNewFrameInternal(const SpdyFramer& framer,
+ uint8_t raw_frame_type,
+ uint8_t flags,
+ SpdyStreamId stream_id,
+ size_t length) {
DCHECK_EQ(0u, stream_id & ~kStreamIdMask);
bool success = true;
SPDY_BUG_IF(framer.GetFrameMaximumSize() < length_)

Powered by Google App Engine
This is Rietveld 408576698