Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Unified Diff: net/spdy/spdy_frame_builder.h

Issue 2794063002: Add a SpdyFramer extension API implementation. (Closed)
Patch Set: Re: #12. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/spdy/spdy_frame_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_frame_builder.h
diff --git a/net/spdy/spdy_frame_builder.h b/net/spdy/spdy_frame_builder.h
index 2715452d90b702b9c371fb32f5f2027562bca9de..9b187260cb161ea90a1d01338428f173ad980042 100644
--- a/net/spdy/spdy_frame_builder.h
+++ b/net/spdy/spdy_frame_builder.h
@@ -54,10 +54,10 @@ class NET_EXPORT_PRIVATE SpdyFrameBuilder {
uint8_t flags,
SpdyStreamId stream_id);
- // Populates this frame with a HTTP2 frame prefix with length information.
- // The given type must be a control frame type.
+ // Populates this frame with a HTTP2 frame prefix with type and length
+ // information.
bool BeginNewFrame(const SpdyFramer& framer,
- SpdyFrameType type,
+ uint8_t type,
xunjieli 2017/04/04 17:07:36 minor nit: could you s/type/raw_frame_type to matc
Bence 2017/04/04 18:46:38 Done.
uint8_t flags,
SpdyStreamId stream_id,
size_t length);
« no previous file with comments | « no previous file | net/spdy/spdy_frame_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698