Index: net/spdy/spdy_frame_builder.h |
diff --git a/net/spdy/spdy_frame_builder.h b/net/spdy/spdy_frame_builder.h |
index 2715452d90b702b9c371fb32f5f2027562bca9de..cd13f5bef4f0f2cc32ace98d8fdd3b565adfd8b9 100644 |
--- a/net/spdy/spdy_frame_builder.h |
+++ b/net/spdy/spdy_frame_builder.h |
@@ -62,6 +62,14 @@ class NET_EXPORT_PRIVATE SpdyFrameBuilder { |
SpdyStreamId stream_id, |
size_t length); |
+ // Populates this frame with a HTTP2 frame prefix with type and length |
+ // information. |
+ bool BeginNewFrame(const SpdyFramer& framer, |
+ uint8_t type, |
xunjieli
2017/04/04 14:36:36
Isn't a SpdyFrameType a uint8_t?
What's the diff b
Bence
2017/04/04 15:19:20
SpdyFrameType is an enum class, and implicit cast
xunjieli
2017/04/04 15:44:41
I see. Function overloads is discouraged per https
Bence
2017/04/04 16:58:47
Sorry, I was not aware of this recommendation from
xunjieli
2017/04/04 17:07:35
Acknowledged. That makes sense.
|
+ uint8_t flags, |
+ SpdyStreamId stream_id, |
+ size_t length); |
+ |
// Takes the buffer from the SpdyFrameBuilder. |
SpdySerializedFrame take() { |
SPDY_BUG_IF(output_ != nullptr) << "ZeroCopyOutputBuffer is used to build " |