Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 279403006: Update WebFrameTestProxy and WebTestProxy to mostly follow Chrome style. (Closed)

Created:
6 years, 7 months ago by dcheng
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

Update WebFrameTestProxy and WebTestProxy to mostly follow Chrome style. This converts most things except parameter and variable names. BUG=360024 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270397

Patch Set 1 #

Patch Set 2 : Try to make it follow renames. #

Patch Set 3 : Hm. #

Patch Set 4 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1534 lines, -3234 lines) Patch
M content/content_shell.gypi View 3 chunks +3 lines, -3 lines 0 comments Download
M content/shell/renderer/shell_content_renderer_client.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/shell/renderer/test_runner/MockColorChooser.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/MockColorChooser.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/renderer/test_runner/MockWebMIDIAccessor.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/MockWebMediaStreamCenter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/MockWebRTCDTMFSenderHandler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/MockWebRTCDataChannelHandler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/MockWebRTCPeerConnectionHandler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/MockWebSpeechRecognizer.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/SpellCheckClient.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/SpellCheckClient.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/TestInterfaces.cpp View 1 chunk +1 line, -1 line 0 comments Download
D content/shell/renderer/test_runner/WebFrameTestProxy.h View 1 chunk +0 lines, -229 lines 0 comments Download
M content/shell/renderer/test_runner/WebTask.h View 1 chunk +2 lines, -2 lines 0 comments Download
D content/shell/renderer/test_runner/WebTestProxy.h View 1 chunk +0 lines, -382 lines 0 comments Download
D content/shell/renderer/test_runner/WebTestProxy.cpp View 1 chunk +0 lines, -1328 lines 0 comments Download
M content/shell/renderer/test_runner/WebUserMediaClientMock.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/event_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/event_sender.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 7 chunks +10 lines, -10 lines 0 comments Download
A content/shell/renderer/test_runner/web_frame_test_proxy.h View 2 1 chunk +280 lines, -0 lines 0 comments Download
A + content/shell/renderer/test_runner/web_test_proxy.h View 1 2 chunks +303 lines, -290 lines 0 comments Download
A + content/shell/renderer/test_runner/web_test_proxy.cc View 1 6 chunks +899 lines, -953 lines 0 comments Download
M content/shell/renderer/webkit_test_runner.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/test/layouttest_support.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dcheng
I left the parameter rename because the diff is already getting pretty useless. I was ...
6 years, 7 months ago (2014-05-13 12:03:44 UTC) #1
jochen (gone - plz use gerrit)
lgtm, thanks
6 years, 7 months ago (2014-05-14 08:28:30 UTC) #2
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 7 months ago (2014-05-14 08:44:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/279403006/60001
6 years, 7 months ago (2014-05-14 08:45:12 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-14 12:26:48 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-14 13:43:35 UTC) #6
Message was sent while issue was closed. 
Change committed as 270397

Powered by Google App Engine
This is Rietveld 408576698