Move ScriptState::forWorld/ScriptState::forMainWorld (Part 1)

third_party/WebKit/Source/bindings/core/v8/V8Binding.h

 /*
 * Copyright (C) 2009 Google Inc. All rights reserved.
 * Copyright (C) 2012 Ericsson AB. All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions are
 * met:
 *
 *     * Redistributions of source code must retain the above copyright
 * notice, this list of conditions and the following disclaimer.
@@ skipping 986 matching lines @@
 CORE_EXPORT v8::Local<v8::Context> toV8Context(ExecutionContext*,
                                                DOMWrapperWorld&);
 // Returns a V8 context associated with a Frame and a DOMWrapperWorld.
 // This method returns an empty context if the frame is already detached.
 CORE_EXPORT v8::Local<v8::Context> toV8Context(LocalFrame*, DOMWrapperWorld&);
 // Like toV8Context but also returns the context if the frame is already
 // detached.
 CORE_EXPORT v8::Local<v8::Context> toV8ContextEvenIfDetached(LocalFrame*,
                                                              DOMWrapperWorld&);
 
+// These methods can return nullptr if the context associated with the
+// ScriptState has already been detached.
+CORE_EXPORT ScriptState* toScriptState(LocalFrame*, DOMWrapperWorld&);
+CORE_EXPORT ScriptState* toScriptStateForMainWorld(LocalFrame*);

[haraken, 2017/04/04 02:26:44]

Nit: I'd add:

  // Do not use this method unless you're pretty sure that you should use the
main world's ScriptState.

People have sometimes abused this method...

[adithyas, 2017/04/04 14:22:42]

Done.

+
 // Returns the frame object of the window object associated with
 // a context, if the window is currently being displayed in a Frame.
 CORE_EXPORT LocalFrame* toLocalFrameIfNotDetached(v8::Local<v8::Context>);
 
 // If 'storage' is non-null, it must be large enough to copy all bytes in the
 // array buffer view into it.  Use allocateFlexibleArrayBufferStorage(v8Value)
 // to allocate it using alloca() in the callers stack frame.
 CORE_EXPORT void toFlexibleArrayBufferView(v8::Isolate*,
                                            v8::Local<v8::Value>,
                                            FlexibleArrayBufferView&,
@@ skipping 131 matching lines @@
 // If the argument isn't an object, this will crash.
 CORE_EXPORT v8::Local<v8::Value> freezeV8Object(v8::Local<v8::Value>,
                                                 v8::Isolate*);
 
 CORE_EXPORT v8::Local<v8::Value> fromJSONString(v8::Isolate*,
                                                 const String& stringifiedJSON,
                                                 ExceptionState&);
 }  // namespace blink
 
 #endif  // V8Binding_h