CRD iOS: Updating remoting service to use oauth and host list fetcher.

remoting/client/ios/facade/host_info.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "remoting/client/ios/facade/host_info.h"
+
+#include "base/logging.h"
+
+namespace remoting {
+
+HostInfo::HostInfo() {}

[joedow, 2017/04/05 22:30:55]

nit: newline

[nicholss, 2017/04/07 18:16:15]

Done.

[joedow, 2017/04/10 16:09:59]

I don't see the newline in the latest patchset.

[nicholss, 2017/04/10 17:49:53]

Ack! Same reason as below, fixed.

+HostInfo::HostInfo(const HostInfo& other) = default;
+
+HostInfo::~HostInfo() {}
+
+bool HostInfo::ParseHostInfo(const base::DictionaryValue& host_info) {
+  const base::ListValue* list_value = nullptr;
+
+  // Add TokenUrlPatterns to HostInfo.
+  if (host_info.GetList("tokenUrlPatterns", &list_value)) {
+    if (!list_value->empty()) {
+      for (const auto& item : *list_value) {
+        std::string token_url_pattern;
+        if (!item->GetAsString(&token_url_pattern)) {
+          return false;
+        }
+        token_url_patterns.push_back(token_url_pattern);
+      }
+    }
+  }
+
+  std::string response_status;
+  host_info.GetString("status", &response_status);
+  if (response_status == "ONLINE") {
+    status = kHostStatusOnline;
+  } else if (response_status == "OFFLINE") {
+    status = kHostStatusOffline;
+  } else {
+    LOG(ERROR) << "Response Status is " << response_status;

[joedow, 2017/04/05 22:30:55]

I'd change this to say "Unknown response status: " so it is more explicit as to
why this is an error.

[nicholss, 2017/04/07 18:16:15]

Done.

[joedow, 2017/04/10 16:09:59]

I don't see this in the latest patchset.

[nicholss, 2017/04/10 17:49:53]

Sorry! I have a copy of this file in an unchecked in folder and my editor
selected that copy and the files are almost the same, the other is my hacking
version... FIXED

+    return false;
+  }
+
+  if (!host_info.GetString("hostId", &host_id)) {
+    LOG(ERROR) << "hostId was not found in host_info";
+    return false;
+  }
+
+  if (!host_info.GetString("hostName", &host_name)) {
+    LOG(ERROR) << "hostName was not found in host_info";
+    return false;
+  }
+
+  if (!host_info.GetString("publicKey", &public_key)) {
+    LOG(ERROR) << "publicKey was not found for " << host_name;
+    return false;
+  }
+
+  // If the host entry was created but the host was never online, then the jid
+  // is never set.
+  if (!host_info.GetString("jabberId", &host_jid) &&
+      status == kHostStatusOnline) {
+    LOG(ERROR) << host_name << " is online but is missing a jabberId";
+    return false;
+  }
+
+  host_info.GetString("hostOfflineReason", &offline_reason);
+
+  return true;
+}
+
+bool HostInfo::IsReadyForConnection() const {
+  return !host_jid.empty() && status == kHostStatusOnline;
+}
+
+}  // namespace remoting