Re-duplicate frontend_accessors.dart.

Re-duplicate frontend_accessors.dart.

This was de-duped in 02573b3caa1f13f68b5c5921b35e4e2e4ca62ab9, however
there's a problem: In order to share type inference and error
detection logic between Fasta's AstBuilder and BodyBuilder classes,
Fasta's use of the accessors needs to be rewritten to make use of the
shadow hierarchy (see
pkg/front_end/lib/src/fasta/builder/shadow_ast.dart), which kernel
shouldn't have to depend on.

R=ahe@google.com

Committed: https://github.com/dart-lang/sdk/commit/80101ac4070bc5ec40765fc6c68a12fb366fe885

[Paul Berry, 2017-04-03 20:20:34]

paulberry@google.com changed reviewers:
+ ahe@google.com

[ahe, 2017-04-04 09:18:50]

lgtm

https://codereview.chromium.org/2794013003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart (right):

https://codereview.chromium.org/2794013003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart:10: final Name
indexGetName = new Name("[]");
We could export these from the kernel version.

https://codereview.chromium.org/2794013003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart:481: Expression
makeLet(VariableDeclaration variable, Expression body) {
These helper methods could probably also be exported from the kernel version.

[Paul Berry, 2017-04-04 16:21:10]

https://codereview.chromium.org/2794013003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart (right):

https://codereview.chromium.org/2794013003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart:10: final Name
indexGetName = new Name("[]");
On 2017/04/04 09:18:50, ahe wrote:
> We could export these from the kernel version.

Done.

https://codereview.chromium.org/2794013003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart:481: Expression
makeLet(VariableDeclaration variable, Expression body) {
On 2017/04/04 09:18:50, ahe wrote:
> These helper methods could probably also be exported from the kernel version.

I'm going to leave these as is for now because I believe that they're going to
need to be rewritten in terms of the AstFactory.

[Paul Berry, 2017-04-04 17:45:20]

https://codereview.chromium.org/2794013003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart (right):

https://codereview.chromium.org/2794013003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart:10: final Name
indexGetName = new Name("[]");
On 2017/04/04 16:21:10, Paul Berry wrote:
> On 2017/04/04 09:18:50, ahe wrote:
> > We could export these from the kernel version.
> 
> Done.

But for some reason this caused test failures which I wasn't able to
understand--at this point I'm suspecting that it exposes a VM bug.  So I'm going
to do it as a follow-up CL and I'll reach out to one of the VM folks to get help
debugging it.

[Paul Berry, 2017-04-04 17:48:55]

Description was changed from

==========
Re-duplicate frontend_accessors.dart.

This was de-duped in 02573b3caa1f13f68b5c5921b35e4e2e4ca62ab9, however
there's a problem: In order to share type inference and error
detection logic between Fasta's AstBuilder and BodyBuilder classes,
Fasta's use of the accessors needs to be rewritten to make use of the
shadow hierarchy (see
pkg/front_end/lib/src/fasta/builder/shadow_ast.dart), which kernel
shouldn't have to depend on.
==========

to

==========
Re-duplicate frontend_accessors.dart.

This was de-duped in 02573b3caa1f13f68b5c5921b35e4e2e4ca62ab9, however
there's a problem: In order to share type inference and error
detection logic between Fasta's AstBuilder and BodyBuilder classes,
Fasta's use of the accessors needs to be rewritten to make use of the
shadow hierarchy (see
pkg/front_end/lib/src/fasta/builder/shadow_ast.dart), which kernel
shouldn't have to depend on.

R=ahe@google.com

Committed:
https://github.com/dart-lang/sdk/commit/80101ac4070bc5ec40765fc6c68a12fb366fe885
==========

[Paul Berry, 2017-04-04 17:48:56]

Committed patchset #1 (id:1) manually as
80101ac4070bc5ec40765fc6c68a12fb366fe885 (presubmit successful).