components/subresource_filter/core/common/test_ruleset_creator.h - Issue 2793993002: [subresource_filter] Replace KMP by std::search.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/core/common/test_ruleset_creator.h

Issue 2793993002: [subresource_filter] Replace KMP by std::search. (Closed)

Patch Set: Address comments from csharrison@ Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/subresource_filter/core/common/test_ruleset_creator.h

diff --git a/components/subresource_filter/core/common/test_ruleset_creator.h b/components/subresource_filter/core/common/test_ruleset_creator.h

index 9ff0b53e2eeb6fada4f806afede6584c68d0d694..afc7a6e4671f9c22a3cba03a79186e44a64dd1d9 100644

--- a/components/subresource_filter/core/common/test_ruleset_creator.h

+++ b/components/subresource_filter/core/common/test_ruleset_creator.h

@@ -85,6 +85,8 @@ class TestRulesetCreator {

void CreateRulesetWithRules(const std::vector<proto::UrlRule>& rules,

TestRulesetPair* test_ruleset_pair);

+ void CreateRulesetWithRules(const std::vector<proto::UrlRule>& rules,

engedy 2017/04/05 10:55:10 nit: CreateUnindexedRulesetWithRulest for consiste

pkalinnikov 2017/04/05 13:29:21 Done.

+ TestRuleset* test_unindexed_ruleset);

// Returns a unique |path| that is valid for the lifetime of this instance.

// No file at |path| will be automatically created.